Issue metadata
Sign in to add a comment
|
1%-5.5% regression in system_health.memory_desktop at 552704:552983 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 1 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12da027dc40000
,
May 1 2018
📍 Found significant differences after each of 4 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12da027dc40000 Separate U2F specific logic in VirtualFidoDevice by hongjunchoi@chromium.org https://chromium.googlesource.com/chromium/src/+/8dab8cfefbdc92721e825a466b1b249ef9842443 Add support for DebugID to vm memory maps by etienneb@chromium.org https://chromium.googlesource.com/chromium/src/+/a1b0ba721f2c3efb3cca43b5bddb54715d2d2b42 Add support for DebugID for macOS. by erikchen@chromium.org https://chromium.googlesource.com/chromium/src/+/0f2bbbfbc10159502a98aebd3e6cf2f44a145c6d Fix LegacyNavigationManagerImpl::FinishGoToIndex. by eugenebut@google.com https://chromium.googlesource.com/chromium/src/+/0796ec8ba7af1e8937b071528ff2aa7156860755 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 3 2018
r552848 (Add support for DebugID for macOS) looks like the significant jump. Assigning to erikchen@ for further investigation.
,
Jun 13 2018
,
Jun 14 2018
The difference is that two more renderers are being spawned. One is a subframe. The other is not clear - maybe it's a prerenderer or something? Over to OOPIF team. I'm particularly curious about this new, unlabeled renderer.
,
Jun 14 2018
Could be the spare process? I don't quite understand why there's a "Subframe:" label in the main frame's process in the first screen shot either-- otherwise it looks like one has Site Isolation with spare process enabled and the other doesn't.
,
Jun 14 2018
,
Oct 9
Hmmm... I think this can be marked as WontFix with the same justification that was used for other bugs reporting increased memory usage after Site Isolation became the default:
It is expected that site-per-process uses more memory - on average
we expect to increase memory usage (e.g. as measured by
Memory.Total.PrivateMemoryFootprint) by around 10%.
The extra renderer process mentioned in #c6 indeed seems to be the spare process which helps ensure that Site Isolation doesn't regress loading metrics (e.g. see http://go/site-isolation-performance#heading=h.ppv7vos32adj).
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 1 2018