Issue metadata
Sign in to add a comment
|
1.2%-86.8% regression in loading.desktop at 552674:552931 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 1 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14d918adc40000
,
May 1 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14d918adc40000 Add ThrottleDelayable 4G params to fieldtrial_testing_config.json by tbansal@chromium.org https://chromium.googlesource.com/chromium/src/+/69c98ffced8e38364bf9c1356f12799269b8e7d5 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 1 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12874743c40000
,
May 1 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16eb0f9dc40000
,
May 1 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16eb0f9dc40000 Speculative fix for crash in RWHVCF::SetTooltipText(). by wjmaclean@chromium.org https://chromium.googlesource.com/chromium/src/+/dcd041159fc60f661b18aa13b9349bff634b532c Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 1 2018
I find it *highly* unlikely that the CL identified in C#6 is responsible (perhaps the metrics don't know how to handle when a browser crash goes away?).
,
May 1 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12874743c40000 Add ThrottleDelayable 4G params to fieldtrial_testing_config.json by tbansal@chromium.org https://chromium.googlesource.com/chromium/src/+/69c98ffced8e38364bf9c1356f12799269b8e7d5 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 1 2018
It is probably my CL since it is related to loading performance. The experiment has been running on M-67+ Canary and Dev on all platforms, but I do not see any regression there. On the contrary, the UMA shows a 0.7% reduction in median FMP on Windows (http://shortn/_mqM6jKRaRV). I will wait to get data from M-67+ Beta channel, and then reevaluate to see what's going on.
,
May 2 2018
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5796dc835bab03d84b1c96a465ab23944a21cdc9 commit 5796dc835bab03d84b1c96a465ab23944a21cdc9 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Jun 27 20:02:30 2018 Revert "Add ThrottleDelayable 4G params to fieldtrial_testing_config.json" This reverts commit 69c98ffced8e38364bf9c1356f12799269b8e7d5. Reason for revert: The field trial experiment was turned down since it did not show any improvement (see http://shortn/_3N4YH2mKyq). Besides, the perf bots showed a regression. Original change's description: > Add ThrottleDelayable 4G params to fieldtrial_testing_config.json > > Bug: 746640 > Change-Id: Ie312a7756f5e6917a4d7c2bd107951f4928e97d0 > Reviewed-on: https://chromium-review.googlesource.com/1024054 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552765} TBR=jwd@chromium.org,tbansal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746640, 838443 Change-Id: I349ed4bdafedeadb8e80af332472937babb7b820 Reviewed-on: https://chromium-review.googlesource.com/1117220 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570875} [modify] https://crrev.com/5796dc835bab03d84b1c96a465ab23944a21cdc9/testing/variations/fieldtrial_testing_config.json
,
Jun 27 2018
Marking as fixed since the field trial was abandoned. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 1 2018