The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/847d298a7a10cb9353e9db9858edb5aa43f2efe8

commit 847d298a7a10cb9353e9db9858edb5aa43f2efe8
Author: Caroline Tice <cmtice@google.com>
Date: Mon May 07 06:51:20 2018

Add -fsanitize-blacklist when CFI is enabled.

In order to work properly CFI needs to use a particular
blacklist.  LLVM used to find the blacklist implicitly, but
the location changed recently and goma builds are looking for
the blacklist in the wrong place.  With this CL, we explicitly
tell LLVM where the blacklist file is.

BUG= chromium:838428 
TEST=Launched two tryjobs on terra-release-tryjob, enabling CFI
on both, but only passing this CL to one of them.  The job with
this CL generated a working chromiumos image; the one without
this CL generated a broken chromiumos image.

Change-Id: I5abaae3cc0c6d32dfa64f517a01fd8ed5f3ed28d
Reviewed-on: https://chromium-review.googlesource.com/1036923
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/847d298a7a10cb9353e9db9858edb5aa43f2efe8/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7aaefdbb734f398eab1da8c47bc122626b803c81

commit 7aaefdbb734f398eab1da8c47bc122626b803c81
Author: Caroline Tice <cmtice@google.com>
Date: Wed May 09 08:11:02 2018

Re-enable CFI on caroline and terra release builders.

Now that we've figured out what was broken when we originally
enabled CFI on caroline and terra, and we have a CL that fixes the
issue, we want to re-enable CFI on those to release builders.

BUG= chromium:838428 
TEST=Launched two terra-release-tryjobs with this CL; one also
used the CL1036923.  The job with both CLs
generated a working chromiumos image; the job with only this
CL generated a broken chromiumos image.

Change-Id: I652c55663ecbe22c790c359951931c80a6d90f50
Reviewed-on: https://chromium-review.googlesource.com/1014251
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/7aaefdbb734f398eab1da8c47bc122626b803c81/cbuildbot/config_dump.json
[modify] https://crrev.com/7aaefdbb734f398eab1da8c47bc122626b803c81/cbuildbot/chromeos_config.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4434e5d6a2fabb9754d7aaf4cca155daba3b65

commit 7e4434e5d6a2fabb9754d7aaf4cca155daba3b65
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 09 10:30:45 2018

Roll src/third_party/chromite/ 9520b5b98..7aaefdbb7 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9520b5b98bd3..7aaefdbb734f

$ git log 9520b5b98..7aaefdbb7 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 cmtice Re-enable CFI on caroline and terra release builders.
2018-05-08 ayatane sysmon: Fix error reference

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:838428 , chromium:840873 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If6a4c93d5ee5c6ce8af44cb19895b5ce12b72dcb
Reviewed-on: https://chromium-review.googlesource.com/1051325
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557138}
[modify] https://crrev.com/7e4434e5d6a2fabb9754d7aaf4cca155daba3b65/DEPS

Looks like this broke simple chrome workflow on caroline (and probably on terra).

clang++-7: error: no such file or directory: '/usr/lib64/clang/7.0.0/share/cfi_blacklist.txt'

manually removing -fsanitize-blacklist fixed the issue.

cmtice@, could you please look into it?

we're tracking this in  issue 837870 

@oshima,  I think the Simple Chrome Workflow issue has been fixed (with a GOMA update).  Could you please check/verify this?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eb01f9d9ab140a8bcf76d9bb0a87f34c9bb88326

commit eb01f9d9ab140a8bcf76d9bb0a87f34c9bb88326
Author: Caroline Tice <cmtice@google.com>
Date: Tue May 15 06:44:18 2018

Revert "Add -fsanitize-blacklist when CFI is enabled."

This reverts commit 847d298a7a10cb9353e9db9858edb5aa43f2efe8.

Reason for revert: This change breaks the simple chrome workflow. We believe the reason is that the path is installed in a different place in simple chrome and the ebuild workflows.

Original change's description:
> Add -fsanitize-blacklist when CFI is enabled.
>
> In order to work properly CFI needs to use a particular
> blacklist.  LLVM used to find the blacklist implicitly, but
> the location changed recently and goma builds are looking for
> the blacklist in the wrong place.  With this CL, we explicitly
> tell LLVM where the blacklist file is.
>
> BUG= chromium:838428 
> TEST=Launched two tryjobs on terra-release-tryjob, enabling CFI
> on both, but only passing this CL to one of them.  The job with
> this CL generated a working chromiumos image; the one without
> this CL generated a broken chromiumos image.
>
> Change-Id: I5abaae3cc0c6d32dfa64f517a01fd8ed5f3ed28d
> Reviewed-on: https://chromium-review.googlesource.com/1036923
> Commit-Ready: Caroline Tice <cmtice@chromium.org>
> Tested-by: Caroline Tice <cmtice@chromium.org>
> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

BUG= chromium:838428 
TEST=None

Change-Id: I4222b07887e9fe658bbcc2c07785399d687caa38
Reviewed-on: https://chromium-review.googlesource.com/1058807
Trybot-Ready: Caroline Tice <cmtice@chromium.org>
Trybot-Ready: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/eb01f9d9ab140a8bcf76d9bb0a87f34c9bb88326/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild