New issue
Advanced search Search tips

Issue 838427 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 832173



Sign in to add a comment

Bluetooth dialog not using shared button styles.

Project Member Reported by dpa...@chromium.org, May 1 2018

Issue description

See before screenshots. Bluetooth dialog should be using shared button styling.

Also note that the "Cancel" button is the right-most button, which is inconsistent with other dialogs.


Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1036602.

See after screenshots.
 
pair_dialog_before.png
11.2 KB View Download
pair_dialog_before2.png
13.1 KB View Download
pair_dialog_before3.png
13.4 KB View Download
pair_dialog_after.png
12.5 KB View Download
pair_dialog_after2.png
13.4 KB View Download
pair_dialog_after3.png
16.8 KB View Download
Blocking: 832173
Labels: -Pri-3 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095a49b96601478ec8cb0a607e5d7bf4b4cc9dd0

commit 095a49b96601478ec8cb0a607e5d7bf4b4cc9dd0
Author: dpapad <dpapad@chromium.org>
Date: Tue May 01 17:02:04 2018

WebUI MD Refresh: Apply shared button styles to bluetooth dialog.

Previously the buttons were using default Polymer style, which is different than
WebUI style. Also in this CL, moving the "Cancel" button to the left, since this
is matching every other dialog in Settings.

Bug:  838427 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77c61b3d0701ba0512e87615a0cf7f8bc0f77766
Reviewed-on: https://chromium-review.googlesource.com/1036602
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555079}
[modify] https://crrev.com/095a49b96601478ec8cb0a607e5d7bf4b4cc9dd0/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html

Status: Fixed (was: Started)

Comment 5 by dpa...@chromium.org, May 22 2018

Labels: Proj-MaterialDesign-Refresh-WebUI

Sign in to add a comment