mojom::NetworkUsage should use unsigned value for total_bytes_received/sent |
||
Issue descriptionThey are signed now because both data sources: * |URLRequest::GetTotalReceivedBytes()| - w/ Network Service, * |ChromeNetworkDelegate::OnNetworkBytesReceived| - w/o Network Service the consumer: * |task_manager::BytesTransferredParam| and the entire //net code are using signed values for bytes transferred. We should consider flipping them to unsigned if that's the suggested pattern. See tsepez@'s comments: https://chromium-review.googlesource.com/c/chromium/src/+/1008969/16/services/network/public/mojom/network_service.mojom#165
,
May 1 2018
Re #c1: Thanks for the comments, that's really helpful! tsepez@ Do you have comments regarding the style guide, or are we using a different one for mojo? https://google.github.io/styleguide/cppguide.html#Integer_Types
,
May 9 2018
WontFix according to #c1. tsepez@ Please reopen if you have other concerns. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by mmenke@chromium.org
, May 1 2018