New issue
Advanced search Search tips

Issue 838423 link

Starred by 1 user
Status: Duplicate
Owner:
jmad...@chromium.org
Closed: May 2018
Cc:
piman@chromium.org
infe...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

angle_enable_vulkan set to true unnecessarily and cause problems for ubsan build

Project Member Reported by zmo@chromium.org, Apr 30 2018 
Looking at angle_enable_vulkan in angle.gni, it seems it's set to true on Windows, Linux/X11, and Android with Vulkan support.

First, this is unnecessary because Chrome isn't shipping with vulkan yet, so it should be guarded by some condition.

Second, this causes ubsan build (is_ubsan_build = true) to stuck (for half an hour at least on my local linux), at vulkan_layer_utils

Comment 1 by zmo@chromium.org, Apr 30 2018 

I need to manually change angle_enable_vulkan to false to complete my ubsan Chrome build. I suspect our ubsan bot has use_x11 set to false, that's why this issue is not stepped on. But this basically blocks developers to complete a ubsan Chrome build.

Comment 2 by piman@chromium.org, May 1 2018 

I should also note, even when we ship Vulkan to users, we shouldn't be enabling, nor shipping validation layers.
And when developing, shouldn't we rely on the validation layers from the OS install and/or the Vulkan SDK, rather than building them ourselves?

Comment 3 by jmad...@chromium.org, May 1 2018

Mergedinto: 837166
Status: Duplicate (was: Assigned)
Duplicating into existing issue. To confirm: we don't ship the validation layers to users.
►

Sign in to add a comment