New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838420 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

"LocalNTPVoiceSearchSmokeTest.MicrophonePermission" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 30 2018

Issue description

"LocalNTPVoiceSearchSmokeTest.MicrophonePermission" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFMb2NhbE5UUFZvaWNlU2VhcmNoU21va2VUZXN0Lk1pY3JvcGhvbmVQZXJtaXNzaW9uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: adithyas@chromium.org
Status: Assigned (was: Untriaged)
This is almost certainly related to https://chromium-review.googlesource.com/c/chromium/src/+/1013687 -- Send no longer appears to delete messages passed to it, causing leaks that get caught by the bot that has LSAN enabled.
Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65befc7904f721450e23308afe7494b699cbf632

commit 65befc7904f721450e23308afe7494b699cbf632
Author: John Budorick <jbudorick@chromium.org>
Date: Tue May 01 02:14:35 2018

Disable LocalNTPVoiceSearchSmokeTest.MicrophonePermission on LSAN.

TBR=treib@chromium.org,sfiera@chromium.org,adithyas@chromium.org

Bug:  838420 
Change-Id: I8e689e62c9eee480eb1f1483a87beabe6a98e26a
Reviewed-on: https://chromium-review.googlesource.com/1036652
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554975}
[modify] https://crrev.com/65befc7904f721450e23308afe7494b699cbf632/chrome/browser/ui/search/local_ntp_voice_search_browsertest.cc

Comment 5 by treib@chromium.org, May 2 2018

Cc: ramyan@chromium.org
Components: UI>Browser>NewTabPage
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: zine-triaged
Project Member

Comment 7 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7716f40b7eca0d4c54535f78a2fe05de1f66575

commit b7716f40b7eca0d4c54535f78a2fe05de1f66575
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Tue May 22 16:55:59 2018

Reenable LocalNTPVoiceSearchSmokeTest.MicrophonePermission

This should have been fixed by https://crrev.com/c/1036230. The source
of the memory being leaked (creating the old IPC messages) was removed
by mojoification.

Bug:  838420 
Change-Id: I115e390cbd458ee71c7eb679bc2f84fb2ee1d823
Reviewed-on: https://chromium-review.googlesource.com/1069120
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560656}
[modify] https://crrev.com/b7716f40b7eca0d4c54535f78a2fe05de1f66575/chrome/browser/ui/search/local_ntp_voice_search_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment