Implement the viewport-fit descriptor as part of the CSS rounded displays spec. This will be part of the viewport meta tag e.g: <meta name='viewport' content='initial-scale=1, viewport-fit=cover'>
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7194888d8a2087cd359817e70aeee8379431103c commit 7194888d8a2087cd359817e70aeee8379431103c Author: Becca Hughes <beccahughes@chromium.org> Date: Wed May 02 21:47:33 2018 Display Cutout: Parse the 'viewport-fit' key Parse the 'viewport-fit' key in the <meta> element and store it on ViewportDescription. BUG= 838400 Change-Id: I0a037175791d4cfaadaa12dffa694eb92a60077d Reviewed-on: https://chromium-review.googlesource.com/1036532 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555562} [modify] https://crrev.com/7194888d8a2087cd359817e70aeee8379431103c/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/7194888d8a2087cd359817e70aeee8379431103c/third_party/blink/renderer/core/dom/viewport_description.h [modify] https://crrev.com/7194888d8a2087cd359817e70aeee8379431103c/third_party/blink/renderer/core/html/html_meta_element.cc [modify] https://crrev.com/7194888d8a2087cd359817e70aeee8379431103c/third_party/blink/renderer/core/html/html_meta_element.h [add] https://crrev.com/7194888d8a2087cd359817e70aeee8379431103c/third_party/blink/renderer/core/html/html_meta_element_test.cc [modify] https://crrev.com/7194888d8a2087cd359817e70aeee8379431103c/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc96e84e51db082e29f6742d43f66fe3879395f4 commit dc96e84e51db082e29f6742d43f66fe3879395f4 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri May 04 22:48:28 2018 Display Cutout: Add feature Add a 'DisplayCutoutAPI' feature that will switch on the viewport-fit code (and the in future css safe-area-* code). BUG= 838400 Change-Id: I6a8f95b1a4cef33349787779ff2993a0f0453bff Reviewed-on: https://chromium-review.googlesource.com/1043078 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556224} [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/chrome/browser/about_flags.cc [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/chrome/browser/flag_descriptions.h [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/content/child/runtime_features.cc [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/content/public/common/content_features.cc [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/content/public/common/content_features.h [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/third_party/blink/public/platform/web_runtime_features.h [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/third_party/blink/renderer/platform/exported/web_runtime_features.cc [modify] https://crrev.com/dc96e84e51db082e29f6742d43f66fe3879395f4/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fda642f0f944120b331a5df95ae08ea2751776d7 commit fda642f0f944120b331a5df95ae08ea2751776d7 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu May 10 18:09:02 2018 Display Cutout: Add viewport-fit descriptor Add support for the viewport-fit @viewport descriptor as part of the CSS Round Display spec. This also wraps ViewportFit in a base::Optional so we know whether the value has been explicitly set. BUG= 838400 Change-Id: I5701fe88fabd4f4246b1ae436cd139d306d8c9f1 Reviewed-on: https://chromium-review.googlesource.com/1047946 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#557586} [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/public/mojom/use_counter/css_property_id.mojom [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/css/CSSProperties.json5 [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/css/parser/css_property_parser.cc [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/dom/document_test.cc [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/dom/viewport_description.h [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/frame/use_counter.cc [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/html/html_meta_element.cc [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/third_party/blink/renderer/core/html/html_meta_element_test.cc [modify] https://crrev.com/fda642f0f944120b331a5df95ae08ea2751776d7/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8043d58567a5854082c43bb47d9020d2d0d1ed51 commit 8043d58567a5854082c43bb47d9020d2d0d1ed51 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue May 29 18:50:35 2018 Display Cutout: Rename runtime feature name The Blink runtime enabled feature name should line up with the Chrome one. BUG= 838400 Change-Id: Ic74d6abf99edf1c1ff8a5b18eedcca34edff9d3b Reviewed-on: https://chromium-review.googlesource.com/1073991 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#562527} [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/content/child/runtime_features.cc [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/public/platform/web_runtime_features.h [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/core/css/CSSProperties.json5 [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/core/dom/document_test.cc [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/core/html/html_meta_element.cc [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/core/html/html_meta_element_test.cc [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/platform/exported/web_runtime_features.cc [modify] https://crrev.com/8043d58567a5854082c43bb47d9020d2d0d1ed51/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82f185792b62f618dac44ebe11c3bf6ea4faa7ef commit 82f185792b62f618dac44ebe11c3bf6ea4faa7ef Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jun 07 22:59:10 2018 Display Cutout: Track ViewportFit in WCO Adds a DisplayCutoutHost mojo interface that is implemented by WebContentsImpl. When ViewportFitChanged is called by the renderer we fire the ViewportFitChanged method on WCO. This allows the browser to change the UI based on the ViewportFit state. On the Blink side changes to ViewportFit bubble up through Document which will call the DisplayCutoutHost Mojo interface. BUG= 838400 Change-Id: I701f8c367167c5d630800f9d41004b88d95f63f3 Reviewed-on: https://chromium-review.googlesource.com/1038786 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#565449} [add] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/content/browser/display_cutout_browsertest.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/content/public/browser/web_contents_observer.h [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/content/test/BUILD.gn [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/public/mojom/BUILD.gn [add] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/public/mojom/page/display_cutout.mojom [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/dom/document_test.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/html/html_meta_element.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/html/html_meta_element.h [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/html/html_meta_element_test.cc [modify] https://crrev.com/82f185792b62f618dac44ebe11c3bf6ea4faa7ef/third_party/blink/renderer/core/page/viewport_description.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edff548179334f3d863524b29488e6d306858e89 commit edff548179334f3d863524b29488e6d306858e89 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Jun 08 01:02:48 2018 Display Cutout: Add controller and factory to Android Add a DisplayCutoutController that will decide when to adjust the layout based on the cutout. This depends on Android P APIs which are called by reflection. BUG= 838400 Change-Id: Iaf808709ded2f3c1b3d7a060942ea8c65396ad9f Reviewed-on: https://chromium-review.googlesource.com/1043248 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#565494} [add] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java [add] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/OWNERS [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/java_sources.gni [add] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutControllerTest.java [add] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/OWNERS [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/content/browser/android/web_contents_observer_proxy.cc [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/content/browser/android/web_contents_observer_proxy.h [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java [modify] https://crrev.com/edff548179334f3d863524b29488e6d306858e89/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b commit cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Jun 08 03:10:07 2018 Revert "Display Cutout: Track ViewportFit in WCO" This reverts commit 82f185792b62f618dac44ebe11c3bf6ea4faa7ef. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 565449 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgyZjE4NTc5MmI2MmY2MThkYWM0NGViZTExYzNiZjZlYTRmYWE3ZWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7501 Sample Failed Step: content_browsertests Original change's description: > Display Cutout: Track ViewportFit in WCO > > Adds a DisplayCutoutHost mojo interface that is implemented > by WebContentsImpl. When ViewportFitChanged is called by > the renderer we fire the ViewportFitChanged method on > WCO. This allows the browser to change the UI based on > the ViewportFit state. > > On the Blink side changes to ViewportFit bubble up through > Document which will call the DisplayCutoutHost Mojo > interface. > > BUG= 838400 > > Change-Id: I701f8c367167c5d630800f9d41004b88d95f63f3 > Reviewed-on: https://chromium-review.googlesource.com/1038786 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565449} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG= 838400 Change-Id: I58be29b1a136e195f01af31dee27a06a9a997341 Reviewed-on: https://chromium-review.googlesource.com/1092270 Cr-Commit-Position: refs/heads/master@{#565525} [delete] https://crrev.com/bd979e0d3b45e6b35ada227070fe46995b807b83/content/browser/display_cutout_browsertest.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/content/public/browser/web_contents_observer.h [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/content/test/BUILD.gn [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/public/mojom/BUILD.gn [delete] https://crrev.com/bd979e0d3b45e6b35ada227070fe46995b807b83/third_party/blink/public/mojom/page/display_cutout.mojom [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/dom/document_test.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/html/html_meta_element.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/html/html_meta_element.h [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/html/html_meta_element_test.cc [modify] https://crrev.com/cf621cf7c6480e35e7a08efd1fbeb2aaa4e1a56b/third_party/blink/renderer/core/page/viewport_description.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/042f8bc36eedd9d5c93862460bc070f4d59813a8 commit 042f8bc36eedd9d5c93862460bc070f4d59813a8 Author: Lei Zhang <thestig@chromium.org> Date: Fri Jun 08 04:13:42 2018 Revert "Display Cutout: Add controller and factory to Android" This reverts commit edff548179334f3d863524b29488e6d306858e89. Reason for revert: This CL depends on r565449, but FindIt reverted r565449 because it caused MSAN errors. So revert this CL as well. Original change's description: > Display Cutout: Add controller and factory to Android > > Add a DisplayCutoutController that will decide when > to adjust the layout based on the cutout. This depends > on Android P APIs which are called by reflection. > > BUG= 838400 > > Change-Id: Iaf808709ded2f3c1b3d7a060942ea8c65396ad9f > Reviewed-on: https://chromium-review.googlesource.com/1043248 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565494} TBR=mlamouri@chromium.org,tedchoc@chromium.org,beccahughes@chromium.org Change-Id: If626817c04b52541d486881b207a259eabf433fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838400 Reviewed-on: https://chromium-review.googlesource.com/1092047 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565529} [delete] https://crrev.com/a13aeb1629034274591dd8d71b445063eebb56e5/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java [delete] https://crrev.com/a13aeb1629034274591dd8d71b445063eebb56e5/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/OWNERS [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/chrome/android/java_sources.gni [delete] https://crrev.com/a13aeb1629034274591dd8d71b445063eebb56e5/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutControllerTest.java [delete] https://crrev.com/a13aeb1629034274591dd8d71b445063eebb56e5/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/OWNERS [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/content/browser/android/web_contents_observer_proxy.cc [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/content/browser/android/web_contents_observer_proxy.h [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java [modify] https://crrev.com/042f8bc36eedd9d5c93862460bc070f4d59813a8/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b commit 6fe54e43769e5b7a4518a5ea6d0115b6d366b78b Author: Becca Hughes <beccahughes@chromium.org> Date: Sat Jun 09 04:18:56 2018 [Reland] Display Cutout: Track ViewportFit in WCO Adds a DisplayCutoutHost mojo interface that is implemented by WebContentsImpl. When ViewportFitChanged is called by the renderer we fire the ViewportFitChanged method on WCO. This allows the browser to change the UI based on the ViewportFit state. On the Blink side changes to ViewportFit bubble up through Document which will call the DisplayCutoutHost Mojo interface. BUG= 838400 Change-Id: If38efdd14b6bb4652448053424090ce5e48aad5c Reviewed-on: https://chromium-review.googlesource.com/1093264 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565845} [add] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/content/browser/display_cutout_browsertest.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/content/public/browser/web_contents_observer.h [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/content/test/BUILD.gn [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/public/mojom/BUILD.gn [add] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/public/mojom/page/display_cutout.mojom [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/dom/document_test.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/html/html_meta_element.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/html/html_meta_element.h [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/html/html_meta_element_test.cc [modify] https://crrev.com/6fe54e43769e5b7a4518a5ea6d0115b6d366b78b/third_party/blink/renderer/core/page/viewport_description.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5560e976415641c35a75bf6181547f805423fd5 commit d5560e976415641c35a75bf6181547f805423fd5 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Jun 11 19:34:40 2018 Reland "Display Cutout: Add controller and factory to Android" This is a reland of edff548179334f3d863524b29488e6d306858e89 This is unchanged and the original CL was reverted due to a reverted dependent CL. TBR=mlamouri@chromium.org Original change's description: > Display Cutout: Add controller and factory to Android > > Add a DisplayCutoutController that will decide when > to adjust the layout based on the cutout. This depends > on Android P APIs which are called by reflection. > > BUG= 838400 > > Change-Id: Iaf808709ded2f3c1b3d7a060942ea8c65396ad9f > Reviewed-on: https://chromium-review.googlesource.com/1043248 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565494} Bug: 838400 Change-Id: I6561b5c1adc785aea9a10e9967701b4e8be9b3ac Reviewed-on: https://chromium-review.googlesource.com/1095454 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#566107} [add] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java [add] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/OWNERS [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/java_sources.gni [add] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutControllerTest.java [add] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/OWNERS [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/content/browser/android/web_contents_observer_proxy.cc [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/content/browser/android/web_contents_observer_proxy.h [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java [modify] https://crrev.com/d5560e976415641c35a75bf6181547f805423fd5/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1beff233d68cb10bd47cedfe8492c5c3d774376b commit 1beff233d68cb10bd47cedfe8492c5c3d774376b Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Jun 11 23:26:42 2018 Display Cutout: Pull safe area values using reflection Add a DisplayCutoutInsetObserverView to listen for safe area value changes and extract them using reflection. Also adds a destroy method to DisplayCutoutController that will clean up the observer view. BUG= 838400 Change-Id: I1ca1e64576e5ced1e3582b0a23fe1fdd8c5faabf Reviewed-on: https://chromium-review.googlesource.com/1068654 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#566199} [modify] https://crrev.com/1beff233d68cb10bd47cedfe8492c5c3d774376b/chrome/android/java/src/org/chromium/chrome/browser/InsetObserverView.java [modify] https://crrev.com/1beff233d68cb10bd47cedfe8492c5c3d774376b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java [modify] https://crrev.com/1beff233d68cb10bd47cedfe8492c5c3d774376b/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java [modify] https://crrev.com/1beff233d68cb10bd47cedfe8492c5c3d774376b/chrome/android/java_sources.gni [add] https://crrev.com/1beff233d68cb10bd47cedfe8492c5c3d774376b/chrome/android/junit/src/org/chromium/chrome/browser/InsetObserverViewTest.java [modify] https://crrev.com/1beff233d68cb10bd47cedfe8492c5c3d774376b/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutControllerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/326c044a30ccc53226a008a26500785dfa0d6ef9 commit 326c044a30ccc53226a008a26500785dfa0d6ef9 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jun 14 06:00:30 2018 Display Cutout: Notify the browser process on fullscreen frame change Notify the browser process when the frame owning the current fullscreen element is changed. Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 BUG= 838400 Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 Reviewed-on: https://chromium-review.googlesource.com/1054441 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567162} [add] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/chrome/browser/ui/exclusive_access/fullscreen_interactive_browsertest.cc [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/chrome/test/BUILD.gn [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/browser/frame_host/render_frame_host_delegate.h [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/common/frame.mojom [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/public/browser/web_contents_observer.h [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/renderer/render_frame_impl.cc [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/renderer/render_frame_impl.h [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/content/test/test_render_frame.cc [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/326c044a30ccc53226a008a26500785dfa0d6ef9/third_party/blink/renderer/core/frame/fullscreen_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd commit ae1580173e207b5bc71ec70a75618ae7a0e8fdcd Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Jun 14 11:17:15 2018 Revert "Display Cutout: Notify the browser process on fullscreen frame change" This reverts commit 326c044a30ccc53226a008a26500785dfa0d6ef9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 567162 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMyNmMwNDRhMzBjY2M1MzIyNmEwMDhhMjY1MDA3ODVkZmEwZDZlZjkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10407 Sample Failed Step: viz_content_browsertests Original change's description: > Display Cutout: Notify the browser process on fullscreen frame change > > Notify the browser process when the frame owning the current > fullscreen element is changed. > > Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 > > BUG= 838400 > > Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 > Reviewed-on: https://chromium-review.googlesource.com/1054441 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567162} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG= 838400 Change-Id: Ifd09d76dcd36d3fe257c8f1a1d6c9a573e86d5e8 Reviewed-on: https://chromium-review.googlesource.com/1100837 Cr-Commit-Position: refs/heads/master@{#567223} [delete] https://crrev.com/2e9ed82ae038f43c191bde697c272297cdf867b1/chrome/browser/ui/exclusive_access/fullscreen_interactive_browsertest.cc [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/chrome/test/BUILD.gn [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/browser/frame_host/render_frame_host_delegate.h [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/common/frame.mojom [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/public/browser/web_contents_observer.h [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/renderer/render_frame_impl.cc [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/renderer/render_frame_impl.h [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/content/test/test_render_frame.cc [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/ae1580173e207b5bc71ec70a75618ae7a0e8fdcd/third_party/blink/renderer/core/frame/fullscreen_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051 commit fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jun 14 18:23:36 2018 Reland "Display Cutout: Notify the browser process on fullscreen frame change" This is a reland of 326c044a30ccc53226a008a26500785dfa0d6ef9 This is unchanged except for a test fix to web_contents_impl_browsertest.cc. TBR=mlamouri@chromium.org,sky@chromium.org,kinuko@chromium.org,foolip@chromium.org Original change's description: > Display Cutout: Notify the browser process on fullscreen frame change > > Notify the browser process when the frame owning the current > fullscreen element is changed. > > Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 > > BUG= 838400 > > Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 > Reviewed-on: https://chromium-review.googlesource.com/1054441 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567162} Bug: 838400 Change-Id: I72c8dff2b4b1d9df5410c3fa14ea32eb5d606ca9 Reviewed-on: https://chromium-review.googlesource.com/1101140 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567351} [add] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/chrome/browser/ui/exclusive_access/fullscreen_interactive_browsertest.cc [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/chrome/test/BUILD.gn [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/browser/frame_host/render_frame_host_delegate.h [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/common/frame.mojom [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/public/browser/web_contents_observer.h [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/renderer/render_frame_impl.cc [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/renderer/render_frame_impl.h [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/content/test/test_render_frame.cc [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/third_party/blink/public/web/web_local_frame_client.h [modify] https://crrev.com/fd5d8f89bbba2f7ee90f17e80ddaba6bb33ae051/third_party/blink/renderer/core/frame/fullscreen_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9e2795d6c1a8a1b94d722ad8d8237edec44a546 commit e9e2795d6c1a8a1b94d722ad8d8237edec44a546 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Jun 25 17:08:27 2018 [Display Cutout] Add effective viewport fit logic Adds logic to DisplayCutoutHostImpl to only use the viewport fit value from the current fullscreen frame. If there is no fullscreen frame then we should default to auto. Also renames a mojo call from ViewportFitChanged to NotifyViewportFitChanged to avoid a naming collision with WebContentsObserver. BUG= 838400 Change-Id: I78498db747739b5def5f19b70563d9ea18612700 Reviewed-on: https://chromium-review.googlesource.com/1105510 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570077} [modify] https://crrev.com/e9e2795d6c1a8a1b94d722ad8d8237edec44a546/content/browser/display_cutout_browsertest.cc [modify] https://crrev.com/e9e2795d6c1a8a1b94d722ad8d8237edec44a546/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/e9e2795d6c1a8a1b94d722ad8d8237edec44a546/third_party/blink/public/mojom/page/display_cutout.mojom [modify] https://crrev.com/e9e2795d6c1a8a1b94d722ad8d8237edec44a546/third_party/blink/renderer/core/dom/document.cc
Comment 1 by mlamouri@chromium.org
, May 1 2018