PathService has: // TODO(brettw) Convert all callers to using the base namespace and remove this. using base::PathService; in the header. It should be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e50fda9c76b6826250f5ea654e2d599199f55df3 commit e50fda9c76b6826250f5ea654e2d599199f55df3 Author: Avi Drissman <avi@chromium.org> Date: Tue May 01 15:49:46 2018 Move some uses of PathService into the base namespace. BUG= 838398 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I454a3c94b2b7c8629791fbbba3ab6e0efd6e9053 Reviewed-on: https://chromium-review.googlesource.com/1036567 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555048} [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/app/main_controller.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/application_context_impl.cc [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/autofill/form_structure_browsertest.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/autofill/validation_rules_storage_factory.cc [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/browser_state/test_chrome_browser_state.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/chrome_paths.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/crash_report/breakpad_helper.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/crash_report/crash_upload_list.cc [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/first_run/first_run.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/ios_chrome_main_parts.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/sessions/session_service_ios_unittest.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/snapshots/snapshots_util.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web/shell/shell_browser_state.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web/shell/shell_url_request_context_getter.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web/shell/shell_web_main_parts.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web/webui/crw_web_ui_manager_unittest.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web/webui/url_fetcher_block_adapter_unittest.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web_view/internal/app/application_context.cc [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web_view/internal/web_view_browser_state.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web_view/internal/web_view_url_request_context_getter.mm [modify] https://crrev.com/e50fda9c76b6826250f5ea654e2d599199f55df3/ios/web_view/internal/web_view_web_main_parts.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/210441b7979870d73aed3e52513ab6cf14336d62 commit 210441b7979870d73aed3e52513ab6cf14336d62 Author: Avi Drissman <avi@chromium.org> Date: Tue May 01 15:51:00 2018 Move some uses of PathService into the base namespace. BUG= 838398 Change-Id: I46fc35c06240f7541bada5ee3118006645b4f6b7 Reviewed-on: https://chromium-review.googlesource.com/1036569 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555050} [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/api/file_system/file_system_api.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/content_hash_fetcher_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/content_verifier_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/content_verify_job_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/extension_icon_image_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/file_reader_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/guest_view/app_view/app_view_apitest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/guest_view/web_view/web_view_apitest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/image_loader_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/info_map_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/path_util.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/path_util_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/sandboxed_unpacker.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/sandboxed_unpacker_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/value_store/value_store_frontend_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/browser/verified_contents_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/common/extension_l10n_util_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/common/extension_paths.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/common/extension_resource_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/common/file_util_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/common/manifest_test.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/renderer/module_system_test.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/app/paths_mac.mm [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/app/shell_main_delegate.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/browser/shell_extension_loader_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/browser/shell_nacl_browser_delegate.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/browser/shell_prefs_unittest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/common/shell_content_client.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/test/shell_apitest.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/shell/test/shell_test.cc [modify] https://crrev.com/210441b7979870d73aed3e52513ab6cf14336d62/extensions/test/extensions_unittests_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cb5e9fec29787e16417082aedee97f647da2403 commit 1cb5e9fec29787e16417082aedee97f647da2403 Author: Avi Drissman <avi@chromium.org> Date: Tue May 01 15:53:28 2018 Move some uses of PathService into the base namespace. BUG= 838398 Change-Id: I720662a54a4270987e45dfa6f5dfcd132f548852 Reviewed-on: https://chromium-review.googlesource.com/1036248 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555051} [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/android/url_request_content_job_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/child_process_launcher_helper_mac.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/cocoa/system_hotkey_map_unittest.mm [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/dom_storage/dom_storage_database_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/download/download_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/download/drag_download_file_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/fileapi/fileapi_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/frame_host/render_frame_host_manager_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/loader/cors_file_origin_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/loader/url_loader_factory_impl_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/media/android/media_resource_getter_impl.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/media/capture/cursor_renderer_aura_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/renderer_host/render_view_host_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/renderer_host/render_widget_host_view_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/web_package/signed_exchange_handler_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/web_package/signed_exchange_header_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/web_package/web_package_request_handler_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/browser/zygote_host/zygote_communication_linux.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/common/child_process_host_impl.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/common/content_paths.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/common/external_ipc_dumper.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/common/page_state_serialization_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/ppapi_plugin/ppapi_plugin_main.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/public/test/content_browser_test.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/public/test/content_browser_test_utils.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/public/test/ppapi_test_utils.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/renderer/media/stream/media_stream_audio_processor_unittest.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/app/blink_test_platform_support_linux.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/app/blink_test_platform_support_win.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/app/paths_mac.mm [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/browser/layout_test/layout_test_devtools_bindings.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/browser/layout_test/test_info_extractor.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/browser/shell_browser_context.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/shell/renderer/layout_test/blink_test_helpers.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/test/image_decoder_test.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/test/ppapi/ppapi_test.cc [modify] https://crrev.com/1cb5e9fec29787e16417082aedee97f647da2403/content/test/test_content_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d43b4b2250aac2829f8fa7eb6603bb299399b13 commit 7d43b4b2250aac2829f8fa7eb6603bb299399b13 Author: Avi Drissman <avi@chromium.org> Date: Tue May 01 16:14:06 2018 Move some uses of PathService into the base namespace. BUG= 838398 Change-Id: I7caf5086058331a595f79320ca58fdbe86a96ff0 Reviewed-on: https://chromium-review.googlesource.com/1036260 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555056} [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/android/chrome_main_delegate_android.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/chrome_crash_reporter_client.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/chrome_crash_reporter_client_mac.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/chrome_exe_main_win.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/main_dll_loader_win.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/app/resources/resources_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/chrome_watcher/chrome_watcher_main.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_content_client.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_paths.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_paths_android.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_paths_linux.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_paths_mac.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_paths_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/chrome_paths_win.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/component_flash_hint_file_linux.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/component_flash_hint_file_linux_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/chrome_extensions_client_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/extension_test_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/extension_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/manifest_tests/chrome_manifest_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/importer/firefox_importer_utils_linux.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/importer/firefox_importer_utils_mac.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/importer/firefox_importer_utils_win.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/logging_chrome.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/mac/app_mode_chrome_locator_browsertest.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/media/cdm_host_file_path.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/safe_browsing/binary_feature_extractor_mac_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/safe_browsing/mach_o_image_reader_mac_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/safe_browsing/pe_image_reader_win_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/service_process_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/service_process_util_linux.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/service_process_util_mac.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/common/service_process_util_win.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/mac/app/testing/Unpacker_test.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/mini_installer/decompress_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/setup/archive_patch_helper_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/setup/installer_crash_reporter_client.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/setup/installer_crash_reporting.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/setup/installer_state_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/test/alternate_version_generator.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/test/alternate_version_generator_main.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/test/upgrade_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/advanced_firewall_manager_win_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/auto_launch_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/google_chrome_distribution.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/install_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/lzma_util_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/master_preferences_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/product_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/installer/util/shell_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/notification_helper/notification_helper_process_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/notification_helper/notification_helper_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/service/service_process.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/services/file_util/public/cpp/sandboxed_zip_analyzer_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/services/util_win/shell_util_win_impl.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/chrome_test_suite.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/chrome_unit_test_suite.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/javascript_browser_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/test_launcher_utils.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/testing_profile.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/ui_test_utils.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/v8_unit_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/base/web_ui_browser_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/chromedriver/chrome_launcher_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/data/webui/webui_resource_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/gpu/webgl_infobar_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/media_router/media_router_base_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/media_router/media_router_integration_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/media_router/media_router_one_ua_integration_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/nacl/nacl_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/nacl/nacl_browsertest_util.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/nacl/pnacl_header_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/ppapi/ppapi_test.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/remoting/remote_desktop_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/test/remoting/webapp_javascript_browsertest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/utility/importer/bookmark_html_reader_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/utility/importer/edge_database_reader_unittest_win.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/utility/importer/firefox_importer_unittest.cc [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/utility/importer/safari_importer_unittest.mm [modify] https://crrev.com/7d43b4b2250aac2829f8fa7eb6603bb299399b13/chrome/utility/safe_browsing/mac/dmg_test_utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c80d834f974d4beba3161cb31f57d09c33e6db0 commit 5c80d834f974d4beba3161cb31f57d09c33e6db0 Author: Avi Drissman <avi@chromium.org> Date: Tue May 01 17:01:19 2018 Move some uses of PathService into the base namespace. BUG= 838398 Change-Id: I70402b8b38ed28f7a1265d706c9824025c43ca1c Reviewed-on: https://chromium-review.googlesource.com/1036568 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555078} [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/base/file_stream_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/cert/internal/test_helpers.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/disk_cache/disk_cache_test_base.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/filter/brotli_source_stream_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/ftp/ftp_directory_listing_parser_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/proxy_resolution/proxy_resolver_v8_tracing_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/proxy_resolution/proxy_resolver_v8_tracing_wrapper_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/proxy_resolution/proxy_resolver_v8_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/spdy/core/fuzzing/hpack_fuzz_util_test.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/embedded_test_server/default_handlers.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/embedded_test_server/embedded_test_server.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/embedded_test_server/embedded_test_server_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/python_utils.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/spawned_test_server/base_test_server.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/spawned_test_server/local_test_server.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/spawned_test_server/local_test_server_posix.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/spawned_test_server/local_test_server_win.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/spawned_test_server/remote_test_server.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/spawned_test_server/remote_test_server_config.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/test/test_data_directory.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/tools/content_decoder_tool/content_decoder_tool_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/tools/crash_cache/crash_cache.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/tools/quic/quic_http_response_cache_test.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/tools/stress_cache/stress_cache.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/tools/tld_cleanup/tld_cleanup.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/url_request/url_fetcher_impl_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/url_request/url_request_file_job_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/url_request/url_request_quic_unittest.cc [modify] https://crrev.com/5c80d834f974d4beba3161cb31f57d09c33e6db0/net/url_request/url_request_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7dee98b85083c81e79fada9a507d48dc63cc267 commit e7dee98b85083c81e79fada9a507d48dc63cc267 Author: Avi Drissman <avi@chromium.org> Date: Tue May 01 17:37:41 2018 Move some uses of PathService into the base namespace. BUG= 838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id4ba77e6861f8d249c198ebc841fdbb5cf31d7f1 Reviewed-on: https://chromium-review.googlesource.com/1036563 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555096} [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/android/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/app_list/test/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/base/l10n/l10n_util_unittest.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/base/resource/data_pack_unittest.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/base/resource/resource_bundle.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/base/resource/resource_bundle_android.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/base/test/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/base/ui_base_paths.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/chromeos/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gfx/gfx_paths.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gfx/icon_util_unittest.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gfx/test/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gl/gl_implementation_osmesa.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gl/init/gl_initializer_mac.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gl/init/gl_initializer_win.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/gl/init/gl_initializer_x11.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/keyboard/keyboard_resource_util.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/keyboard/test/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/message_center/test/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/ozone/common/egl_util.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/shell_dialogs/run_all_unittests.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views/examples/examples_main.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views/test/views_interactive_ui_test_base.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views/views_test_suite.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views_content_client/views_content_client_main_parts_mac.mm [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/views_content_client/views_content_main_delegate.cc [modify] https://crrev.com/e7dee98b85083c81e79fada9a507d48dc63cc267/ui/wm/test/run_all_unittests.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f617d01a04196951c9dfbc5234bf3b2b61b751fc commit f617d01a04196951c9dfbc5234bf3b2b61b751fc Author: Avi Drissman <avi@chromium.org> Date: Wed May 02 18:48:53 2018 Move some uses of PathService into the base namespace. BUG= 838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8df9263f159af6a1152b46882a80bec0c52a822d Reviewed-on: https://chromium-review.googlesource.com/1036566 Reviewed-by: Doug Steedman <dougsteed@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555487} [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/arc/test/fake_app_instance.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/autofill/core/browser/autofill_merge_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/autofill/core/browser/autofill_profile_validation_util_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/autofill/core/browser/field_filler_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/autofill/core/browser/subkey_requester_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/bookmarks/browser/bookmark_codec_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/browser_watcher/window_hang_monitor_win_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/cast_certificate/cast_cert_validator_test_helpers.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/cast_channel/cast_socket_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/component_updater/component_installer.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/component_updater/component_installer_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/component_updater/component_updater_paths.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/crash/content/app/breakpad_linux.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/crash/content/app/crashpad_linux.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/cronet/ios/cronet_environment.mm [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/cronet/ios/test/cronet_prefs_test.mm [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/crx_file/crx_creator_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/crx_file/crx_verifier_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/dom_distiller/core/page_features_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/dom_distiller/standalone/content_extractor_browsertest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/drive/chromeos/file_cache_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/history/core/test/database_test_utils.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/image_fetcher/ios/webp_decoder_unittest.mm [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/json_schema/json_schema_validator_unittest_base.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/metrics/drive_metrics_provider.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/metrics/machine_id_provider_win.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/nacl/broker/nacl_broker_listener.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/nacl/browser/nacl_browser.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/nacl/common/nacl_paths.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/nacl/zygote/nacl_fork_delegate_linux.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/ntp_tiles/icon_cacher_impl_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/offline_pages/content/renovations/test/page_renovator_browsertest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/offline_pages/core/archive_validator_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/omnibox/browser/in_memory_url_index_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/omnibox/browser/shortcuts_database_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/password_manager/core/browser/android_affiliation/affiliation_database_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/password_manager/core/browser/login_database_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/pdf/renderer/pdf_accessibility_tree_browsertest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/policy/core/common/preg_parser_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/safe_browsing/db/prefix_set_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/search_provider_logos/google_logo_api_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/services/filesystem/file_system_app.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/spellcheck/renderer/spellcheck_multilingual_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/spellcheck/renderer/spellcheck_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/subresource_filter/core/common/perftests/indexed_ruleset_perftest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/sync/test/local_sync_test_server.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/test/components_test_suite.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/component_patcher_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/component_unpacker_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/crx_downloader_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/request_sender_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/update_client_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/update_client/utils_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/url_formatter/url_fixer.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/viz/service/display/bsp_tree_perftest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/viz/test/paths.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/webcrypto/algorithms/test_helpers.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/webdata/common/web_database_migration_unittest.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/wifi/wifi_service_win.cc [modify] https://crrev.com/f617d01a04196951c9dfbc5234bf3b2b61b751fc/components/zucchini/integration_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9098f900d68af46e15806188fb60f51c1682207a commit 9098f900d68af46e15806188fb60f51c1682207a Author: Avi Drissman <avi@chromium.org> Date: Fri May 04 00:11:52 2018 Move some uses of PathService into the base namespace. BUG= 838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I0cf62fc688cdcd8b05320f1eb96543c50a8fca51 Reviewed-on: https://chromium-review.googlesource.com/1036249 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#555920} [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/about_flags_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/autocomplete/keyword_extensions_delegate_impl_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/autofill/form_structure_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/autofill/validation_rules_storage_factory.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/browser_shutdown.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/captive_portal/captive_portal_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chrome_browser_main_android.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chrome_browser_main_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chrome_plugin_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_data.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/app_mode/fake_cws.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/customization/customization_document.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/extensions/default_app_order.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/file_manager/file_manager_jstest_base.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/file_manager/file_manager_uitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/file_manager/open_with_browser.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/enable_debugging_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/login_manager_test.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/resource_loader_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/saml/saml_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/startup_utils.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/test/https_forwarder.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/test/oobe_base_test.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/affiliation_test_helper.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_local_account_policy_service.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/power_policy_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/settings/install_attributes_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/system/automatic_reboot_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/tpm_firmware_update.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/chromeos/tpm_firmware_update_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/component_installers_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/component_patcher_operation_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/cros_component_installer.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/pepper_flash_component_installer.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/pnacl_component_installer.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/recovery_component_installer.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/crash_upload_list/crash_upload_list.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/devtools/devtools_file_system_indexer_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/devtools/remote_debugging_server.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/diagnostics/diagnostics_controller_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/diagnostics/diagnostics_model.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/diagnostics/diagnostics_test.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/diagnostics/recon_diagnostics.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/diagnostics/sqlite_diagnostics.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/downgrade/user_data_downgrade.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/downgrade/user_data_downgrade_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/download/download_path_reservation_tracker.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/download/download_prefs.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/download/download_target_determiner_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/download/save_page_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/debugger/debugger_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/file_system/file_system_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/platform_keys/platform_keys_test_base.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/api/sessions/sessions_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/app_background_page_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/browsertest_util.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/chrome_component_extension_resource_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/chrome_info_map_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/chrome_url_request_util.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/component_loader.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/component_loader_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/content_capabilities_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/convert_user_script_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/convert_web_app_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_icon_manager_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_messages_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_prefs_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_protocols_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_service_test_base.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_startup_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/extension_webui_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/external_pref_loader.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/external_provider_impl_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/lazy_background_page_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/pack_extension_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/plugin_manager.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/startup_helper_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/updater/chromeos_extension_cache_delegate.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/user_script_listener_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/webstore_installer.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/window_open_apitest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/extensions/zipfile_installer_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/file_select_helper_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/first_run.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/first_run_internal_linux.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/first_run_internal_posix.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/first_run_internal_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/first_run_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/upgrade_util_linux.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/first_run/upgrade_util_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/google/google_update_settings_posix.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/google/google_update_settings_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/google/google_update_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/google/google_update_win_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/history/android/android_urls_database_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/importer/edge_importer_browsertest_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/importer/firefox_importer_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/load_library_perf_test.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/local_discovery/service_discovery_shared_client.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/mac/relauncher.mm [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/media_engagement_autoplay_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/media_engagement_preloaded_list_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/webrtc/webrtc_browsertest_common.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media/wv_test_license_server_config.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media_galleries/media_file_system_registry_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media_galleries/media_galleries_permission_controller.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media_galleries/media_galleries_preferences.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/memory_details_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/metrics/antivirus_metrics_provider_win.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/metrics/desktop_session_duration/audible_contents_tracker_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/metrics/metrics_service_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/metrics/testing/metrics_reporting_pref_helper.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc [modify] https://crrev.com/9098f900d68af46e15806188fb60f51c1682207a/chrome/browser/net/chrome_network_delegate.cc [modify] https://cr
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea15ea06b514d9a95af39d7e35235fdf948da0c8 commit ea15ea06b514d9a95af39d7e35235fdf948da0c8 Author: Avi Drissman <avi@chromium.org> Date: Mon May 07 18:55:12 2018 Fully move PathService into the base namespace. BUG= 838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ibb79d0d8090cece52d7a20269153718992c8c2d1 Reviewed-on: https://chromium-review.googlesource.com/1036570 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#556512} [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/aw_browser_context.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/aw_browser_main_parts.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/aw_metrics_service_client.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/aw_safe_browsing_ui_manager.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/cookie_manager.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/browser/net/aw_url_request_context_getter.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/common/aw_paths.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ash/app_list/presenter/test/run_all_unittests.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ash/display/display_color_manager_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ash/shell/content/client/shell_main_delegate.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ash/shell/content/shell_with_content_main.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ash/test/ash_interactive_ui_test_base.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ash/test/ash_test_suite.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/base/file_version_info_win_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/base/path_service.h [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/base/test/generate_fontconfig_caches.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/base/test/test_support_android.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cc/test/layer_tree_pixel_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cc/test/pixel_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cc/trees/layer_tree_host_common_perftest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cc/trees/layer_tree_host_perftest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/app/main_dll_loader_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/chrome_browser_main_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/chromeos/login/test/https_forwarder.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/extensions/extension_nacl_browsertest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/net/chrome_network_delegate.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/offline_pages/android/offline_page_model_factory.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/offline_pages/test_offline_page_model_builder.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/printing/pdf_to_emf_converter_browsertest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/shell_integration_linux.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/task_manager/sampling/shared_sampler_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/browser/web_applications/web_app_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/installer/util/helper.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/installer/util/install_util.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/installer/util/logging_installer.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome/test/chromedriver/chrome/chrome_finder.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome_elf/blacklist/test/blacklist_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chrome_elf/elf_imports_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/app/android/cast_crash_reporter_client_android.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/app/cast_main_delegate.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/base/cast_paths.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/base/path_utils.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/base/path_utils_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/browser/cast_browser_context.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/browser/pref_service_helper.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/common/cast_resource_delegate.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/crash/linux/minidump_uploader.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromeos/chromeos_paths.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromeos/chromeos_test_utils.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromeos/dbus/fake_cryptohome_client.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromeos/dbus/fake_session_manager_client.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromeos/services/assistant/platform/file_provider_impl.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/chromeos/system/statistics_provider.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cloud_print/common/win/install_utils.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cloud_print/virtual_driver/win/install/setup.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/components/component_updater/component_installer_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/components/nacl/zygote/nacl_fork_delegate_linux.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/components/policy/core/common/policy_loader_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/content/browser/frame_host/blocked_scheme_navigation_browsertest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/courgette/base_test_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/crypto/nss_util.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/device/test/usb_test_gadget_impl.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/gin/shell/gin_shell_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/gin/v8_initializer.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/google_apis/drive/test_util.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/google_apis/gaia/fake_gaia.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/gpu/gles2_conform_support/gles2_conform_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/gpu/khronos_glcts_support/khronos_glcts_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/headless/lib/browser/headless_browser_context_impl.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/headless/lib/browser/headless_content_browser_client.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/headless/lib/headless_content_main_delegate.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/headless/test/headless_browser_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/headless/test/headless_js_bindings_browsertest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/mash/test/mash_test_suite.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/base/test_data_util.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/cast/test/simulator.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/cdm/external_clear_key_test_helper.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/filters/ffmpeg_demuxer_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/filters/file_data_source_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/filters/jpeg_parser_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/media/gpu/windows/dxva_video_decode_accelerator_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/mojo/edk/test/test_support_impl.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/pdf/pdfium/findtext_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/printing/backend/cups_helper.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/printing/emf_win_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/remoting/host/branding.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/remoting/host/file_transfer_message_handler.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/remoting/host/ipc_constants.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/remoting/host/resources_linux.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/remoting/host/setup/daemon_controller_delegate_linux.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/remoting/test/frame_generator_util.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/rlz/chromeos/lib/rlz_value_store_chromeos.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/sandbox/linux/suid/client/setuid_sandbox_host.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/sandbox/win/src/address_sanitizer_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/sandbox/win/src/process_mitigations_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/catalog/entry_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/network/url_loader_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/service_manager/runner/host/service_process_launcher_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/service_manager/sandbox/win/sandbox_win.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/shape_detection/face_detection_impl_win_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/shape_detection/text_detection_impl_win_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/services/test/run_all_service_tests.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/sql/recovery_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/sql/test/paths.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/testing/libfuzzer/tests/fuzzer_launcher_test.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/third_party/liblouis/nacl_wrapper/liblouis_wrapper_browsertest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/third_party/zlib/google/zip_reader_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/third_party/zlib/google/zip_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/tools/battor_agent/battor_agent_bin.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/tools/gn/command_format_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/tools/gn/ninja_build_writer.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/ui/compositor/layer_unittest.cc [modify] https://crrev.com/ea15ea06b514d9a95af39d7e35235fdf948da0c8/webrunner/app/webrunner_main_delegate.cc
Comment 1 by bugdroid1@chromium.org
, May 1 2018