New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838388 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Left Chrome team
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove MobileStartup.MainIntentAction/MobileStartup.NonMainIntentAction

Project Member Reported by mariakho...@chromium.org, Apr 30 2018

Issue description

These histograms don't quite fire at the right times and are more misleading than useful.
 
Labels: Hotlist-Metrics
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e

commit c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Tue May 22 18:03:50 2018

Remove StartupMetrics.java

These metrics are incorrect because they detect MAIN vs non-MAIN behaviour wrong
since the intent gets updated in onNewIntent(), but we set the intent in
onStart(). These are also incorrect because they get recorded every time
we call onStart(), which means that when we go to settings and come back
we would record the metric again.

Bug:  838388 
Change-Id: Id8bb7b3401c8103029d5b397a57bb1f07dc56b26
Reviewed-on: https://chromium-review.googlesource.com/1062937
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560702}
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[delete] https://crrev.com/0ba5d72d6e2fac815d26544f4bda7d123e01b4e8/chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/chrome/android/java_sources.gni
[modify] https://crrev.com/c8e9faef1c3a27cd0daee222b8c491f93e4f1a0e/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment