IndexedDBBackingStore should have thread checks |
|||||
Issue descriptionIndexedDBBackingStore currently lacks thread-checks, as a result of which it passes its unit-tests, even when they access or teardown e.g. Transactions on the wrong threads.
,
Apr 30 2018
FWIW, started a CL at https://chromium-review.googlesource.com/c/chromium/src/+/1036445 for some of this.
,
May 1 2018
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce25071d1d2b3bc35f34bdcc48a1d0a90d86e9df commit ce25071d1d2b3bc35f34bdcc48a1d0a90d86e9df Author: Wez <wez@chromium.org> Date: Sat May 12 22:12:07 2018 Add thread checks to IndexedDBBackingStore classes and fix tests. Bug: 838386 Change-Id: I614e823499c927704ed95d76103bf1e1c2c216f0 Reviewed-on: https://chromium-review.googlesource.com/1036445 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#558144} [modify] https://crrev.com/ce25071d1d2b3bc35f34bdcc48a1d0a90d86e9df/content/browser/indexed_db/indexed_db_backing_store.cc [modify] https://crrev.com/ce25071d1d2b3bc35f34bdcc48a1d0a90d86e9df/content/browser/indexed_db/indexed_db_backing_store_unittest.cc [modify] https://crrev.com/ce25071d1d2b3bc35f34bdcc48a1d0a90d86e9df/content/browser/indexed_db/indexed_db_fake_backing_store.cc
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c655bcf2798dff39bbebaa2d4eeb276f7a0bfff4 commit c655bcf2798dff39bbebaa2d4eeb276f7a0bfff4 Author: Wez <wez@chromium.org> Date: Mon May 14 01:39:46 2018 Do not tolerate null TaskRunner in IndexedDBBackingStore. Allowances were added in thread checks, but these are no longer required since the fake for this class now grabs the calling-thread's TaskRunner. Bug: 838386 Change-Id: I27bc5bc192067ac5fc6c1636108dad30e92190f0 Reviewed-on: https://chromium-review.googlesource.com/1056252 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#558171} [modify] https://crrev.com/c655bcf2798dff39bbebaa2d4eeb276f7a0bfff4/content/browser/indexed_db/indexed_db_backing_store.cc
,
May 14 2018
dmurph: Assigning to you in case there are any further checks you'd like to add to this code, e.g. I haven't touched the *Transaction or other helper classes, for example.
,
Jan 3
,
Jan 3
Removing myself from blocked issues
,
Jan 3
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jsb...@chromium.org
, Apr 30 2018