New issue
Advanced search Search tips

Issue 838364 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 826950



Sign in to add a comment

Client hints header value is set incorrectly for main frame navigations

Project Member Reported by tbansal@chromium.org, Apr 30 2018 
If the origin server has opted in to receiving downlink client hint, then the client hints value set during the main frame navigation may have a incorrect value.

This is because of a bug in RoundMbps()  (file: chrome/browser/client_hints/client_hints.h) which assumes that the provided argument is downlink value in Mbps whereas in fact, the caller calls it with a Kbps value.
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceab959433805c5e314680e3e6a70d054698dc28

commit ceab959433805c5e314680e3e6a70d054698dc28
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue May 01 18:57:35 2018

Fix kbps to mbps conversion when attaching client hints

When downlink client hint is attached to the request during main
frame navigation, convert kbps to Mbps correctly.

Change-Id: If0b12bb2eb0acc85ed64d349ca0e28f2c6a0b025
Bug:  838364 
Reviewed-on: https://chromium-review.googlesource.com/1036190
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555127}
[modify] https://crrev.com/ceab959433805c5e314680e3e6a70d054698dc28/chrome/browser/client_hints/client_hints.cc
[modify] https://crrev.com/ceab959433805c5e314680e3e6a70d054698dc28/chrome/browser/client_hints/client_hints.h
[modify] https://crrev.com/ceab959433805c5e314680e3e6a70d054698dc28/chrome/browser/client_hints/client_hints_browsertest.cc
[modify] https://crrev.com/ceab959433805c5e314680e3e6a70d054698dc28/chrome/browser/client_hints/client_hints_unittest.cc

Comment 2 by tbansal@chromium.org, May 1 2018

Blocking: 826950
Labels: -M-67 M-68
Status: Fixed (was: Started)
►

Sign in to add a comment