New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838360 link

Starred by 1 user
Status: Fixed
Owner:
derat@chromium.org
Closed: May 2018
Cc:
vapier@chromium.org
█ jachuang@chromium.org
yueherngl@chromium.org
zhuohao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Replace acpi_ac_off USE flag with acpi_ac

Project Member Reported by derat@chromium.org, Apr 30 2018 
We currently have a acpi_ac_off USE flag that gets set in board overlays where we want to disable the ACPI AC driver in the kernel (typically because they have USB Type-C ports and we want to use the PD driver instead). acpi_ac_off is listed in CONFIG_FRAGMENTS in the cros-kernel2.eclass file and then used to disable CONFIG_ACPI_AC in the kernel config:

acpi_ac_off_desc="Turn off ACPI AC"
acpi_ac_off_config="
# CONFIG_ACPI_AC is not set
"

This feels backwards from the usual way that USE flags work, i.e. it'd usually instead be named acpi_ac, enabled by default, and then explicitly unset in board overlays that want to disable the driver.
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1964e5549f5f30ef3916400d859be1c07139bc3a

commit 1964e5549f5f30ef3916400d859be1c07139bc3a
Author: Daniel Erat <derat@chromium.org>
Date: Thu May 10 22:09:37 2018

overlays: Unset acpi_ac instead of setting acpi_ac_off.

Make boards that were setting the acpi_ac_off USE flag to
disable the ACPI AC kernel driver instead unset a new
on-by-default acpi_ac USE flag.

Also unset acpi_ac in overlay-lakitu to fix
kernel_LakituConfigVerify errors that occur otherwise.

BUG= chromium:838360 
TEST=none
RELEASE_NOTE=None
CQ-DEPEND=I2f340f6425caeb8163ae84738c154fc815f14662

Change-Id: I61b5c08d8e9fb50977a0a91f21392405acd3d8d8
Reviewed-on: https://chromium-review.googlesource.com/1036186
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Aditya Kali <adityakali@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/overlay-nautilus/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/overlay-poppy/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/overlay-samus/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/chipset-skl/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/overlay-soraka/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/chipset-apl/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/overlay-eve/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/overlay-lakitu/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/chipset-stnyridge/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/baseboard-nami/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/chipset-glk/profiles/base/make.defaults
[modify] https://crrev.com/1964e5549f5f30ef3916400d859be1c07139bc3a/chipset-cnl/profiles/base/make.defaults
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/331c176c3df9be2ce4c5d46859f8f9964fe91f50

commit 331c176c3df9be2ce4c5d46859f8f9964fe91f50
Author: Daniel Erat <derat@chromium.org>
Date: Thu May 10 22:09:36 2018

cros-kernel2: Replace acpi_ac_off USE flag with acpi_ac.

Update cros-kernel2.eclass to use a set-by-default acpi_ac
USE flag rather than an unset-by-default acpi_ac_off for
controlling CONFIG_ACPI_AC.

BUG= chromium:838360 
TEST=none
CQ-DEPEND=I61b5c08d8e9fb50977a0a91f21392405acd3d8d8

Change-Id: I2f340f6425caeb8163ae84738c154fc815f14662
Reviewed-on: https://chromium-review.googlesource.com/1036187
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/331c176c3df9be2ce4c5d46859f8f9964fe91f50/profiles/targets/chromeos/make.defaults
[modify] https://crrev.com/331c176c3df9be2ce4c5d46859f8f9964fe91f50/eclass/cros-kernel2.eclass

Comment 3 by derat@chromium.org, May 10 2018

Status: Fixed (was: Started)
►

Sign in to add a comment