[MacViews Browser] Can't drag window |
|||
Issue descriptionThis is ToT, 0e2475399b7880788edf96b2cfa0059eb7e986cc. I built with a jumbo build (dunno if that matters) and with --enable-features=ViewsBrowserWindows I can't drag a window from the gray top of the window area.
,
Apr 30 2018
This only affects macOS 10.11 and older.
,
Apr 30 2018
As noted by sdy, this is 10.11, which matters.
,
May 1 2018
Window dragging on 10.11 must have been in a weird place. The construction stripe window (just a child window) made this problem not show up in Chromium. I guess that's a case against having it!
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bf450504615961b3043e96364cde3360387be72 commit 7bf450504615961b3043e96364cde3360387be72 Author: Sidney San Martín <sdy@chromium.org> Date: Wed May 02 18:57:50 2018 Extend the workaround for broken MacViews window dragging to 10.11. I didn't catch that it was needed on 10.11 up front because the presence of the window that shows construction stripes in Chromium builds made the problem vanish. Weird stuff. Bug: 838353 Change-Id: I7cf9e352ff51dccfdbc561da58905175dab68742 Reviewed-on: https://chromium-review.googlesource.com/1038624 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555491} [modify] https://crrev.com/7bf450504615961b3043e96364cde3360387be72/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
,
May 2 2018
,
May 21 2018
Don't you need to apply the fix to native_widget_mac_frameless_nswindow.mm as well? |
|||
►
Sign in to add a comment |
|||
Comment 1 by sdy@chromium.org
, Apr 30 2018Owner: sdy@chromium.org