New issue
Advanced search Search tips

Issue 838337 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Dec 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug


Previous locations:
gerrit:8839


Sign in to add a comment

Upload fails, error 500, left with 404, commit message lost

Project Member Reported by danakj@chromium.org, Apr 24 2018

Issue description

Note that it sat at "Waiting for emacs..." for a long time. Eventually it started to make progress, but ultimately failed. The CL is a 404 on gerrit, but the git cl issue reports the CL number.



Running presubmit upload checks ...
Done processing /usr/local/google/home/danakj/s/c/src/cc/raster/one_copy_raster_buffer_provider.cc
Done processing /usr/local/google/home/danakj/s/c/src/cc/raster/one_copy_raster_buffer_provider.h
Done processing /usr/local/google/home/danakj/s/c/src/cc/raster/raster_buffer_provider_unittest.cc
Done processing /usr/local/google/home/danakj/s/c/src/cc/raster/staging_buffer_pool.cc
Done processing /usr/local/google/home/danakj/s/c/src/cc/raster/staging_buffer_pool.h
Done processing /usr/local/google/home/danakj/s/c/src/cc/raster/staging_buffer_pool_unittest.cc
Done processing /usr/local/google/home/danakj/s/c/src/cc/resources/layer_tree_resource_provider.cc
Done processing /usr/local/google/home/danakj/s/c/src/cc/resources/layer_tree_resource_provider.h
Done processing /usr/local/google/home/danakj/s/c/src/cc/test/layer_tree_pixel_resource_test.cc
Done processing /usr/local/google/home/danakj/s/c/src/cc/trees/layer_tree_host_impl.cc

Presubmit checks took 5.0s to calculate.

Presubmit checks passed.
 cc/raster/one_copy_raster_buffer_provider.cc | 19 +++++++++----------
 cc/raster/one_copy_raster_buffer_provider.h  |  6 +++---
 cc/raster/raster_buffer_provider_unittest.cc |  2 +-
 cc/raster/staging_buffer_pool.cc             |  7 +++----
 cc/raster/staging_buffer_pool.h              |  7 ++++---
 cc/raster/staging_buffer_pool_unittest.cc    |  5 ++---
 cc/resources/layer_tree_resource_provider.cc |  1 -
 cc/resources/layer_tree_resource_provider.h  |  3 ---
 cc/test/layer_tree_pixel_resource_test.cc    |  3 +--
 cc/trees/layer_tree_host_impl.cc             |  4 ++--
 10 files changed, 25 insertions(+), 32 deletions(-)
Waiting for Emacs...
remote: 
remote: Processing changes: new: 1, done            
remote: (W) aa302f0: commit subject >50 characters; use shorter first paragraph        
remote: 
remote: New Changes:        
remote:   https://chromium-review.googlesource.com/#/c/chromium/src/+/1026850 cc: Remove sync_query from LayerTreeResourceProvider [WIP]        
remote: 
To https://chromium.googlesource.com/chromium/src.git
 * [new branch]                aa302f09bdc8eb8ff9d7b9b2da63d44d111f6337 -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=cc
[W2018-04-24 18:49:21,412 34261 140087059457792 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026850/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-24 18:49:22,534 34261 140087059457792 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026850/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-24 18:49:24,629 34261 140087059457792 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026850/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-24 18:49:28,717 34261 140087059457792 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026850/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-24 18:49:36,834 34261 140087059457792 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026850/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-24 18:49:52,961 34261 140087059457792 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026850/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
Traceback (most recent call last):
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 6038, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 6020, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/danakj/s/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 5058, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 1618, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 3121, in CMDUploadChange
    notify=bool(options.send_mail))
  File "/usr/local/google/home/danakj/s/depot_tools/gerrit_util.py", line 722, in AddReviewers
    resp = ReadHttpJsonResponse(conn, accept_statuses=accept_statuses)
  File "/usr/local/google/home/danakj/s/depot_tools/gerrit_util.py", line 432, in ReadHttpJsonResponse
    fh = ReadHttpResponse(conn, accept_statuses)
  File "/usr/local/google/home/danakj/s/depot_tools/gerrit_util.py", line 426, in ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Not Found: Not found: 1026850


 

Comment 1 by danakj@chromium.org, Apr 24 2018

Summary: Upload fails, error 500, left with 404, commit message lost (was: Upload fails, left with 404, commit message lost)
This occurs repeatedly trying to upload this branch to create a CL. The long pause was a red herring.

Comment 2 by danakj@chromium.org, Apr 24 2018

Ok it "worked" and left me with a CL: https://chromium-review.googlesource.com/c/chromium/src/+/1026839

However still was full of errors on the console, and failed to add the watchlist ccs, my specified reviewer, or ccs.

remote: Processing changes: new: 1, done            
remote: (W) a33b32d: commit subject >50 characters; use shorter first paragraph        
remote: 
remote: New Changes:        
remote:   https://chromium-review.googlesource.com/#/c/chromium/src/+/1026839 cc: Remove sync_query from LayerTreeResourceProvider [WIP]        
remote: 
To https://chromium.googlesource.com/chromium/src.git
 * [new branch]                a33b32deef4d8f6326dedfc287d9c1a412882f26 -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=cc
[W2018-04-24 18:53:32,792 67403 139855304603392 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026839/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-24 18:53:33,906 67403 139855304603392 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026839/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-24 18:53:36,138 67403 139855304603392 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026839/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-24 18:53:40,280 67403 139855304603392 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026839/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-24 18:53:48,401 67403 139855304603392 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026839/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-24 18:54:04,513 67403 139855304603392 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/1026839/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
Traceback (most recent call last):
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 6038, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 6020, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/danakj/s/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 5058, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 1618, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
  File "/usr/local/google/home/danakj/s/depot_tools/git_cl.py", line 3121, in CMDUploadChange
    notify=bool(options.send_mail))
  File "/usr/local/google/home/danakj/s/depot_tools/gerrit_util.py", line 722, in AddReviewers
    resp = ReadHttpJsonResponse(conn, accept_statuses=accept_statuses)
  File "/usr/local/google/home/danakj/s/depot_tools/gerrit_util.py", line 432, in ReadHttpJsonResponse
    fh = ReadHttpResponse(conn, accept_statuses)
  File "/usr/local/google/home/danakj/s/depot_tools/gerrit_util.py", line 426, in ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Not Found: Not found: 1026839

Comment 3 by logan@google.com, Apr 30 2018

Project: chromium
Moved issue gerrit:8839 to now be  issue chromium:838337 .

Comment 4 by logan@google.com, Apr 30 2018

Components: Infra>Codereview>Gerrit
Labels: -Priority-1
Cc: ajp@chromium.org
Mergedinto: 881860
Status: Duplicate (was: New)
I'm not sure about the initial 500 response, but this feels like a dupe of the larger git cl upload 404 issue we've 99.9% fixed. Marking it as a dupe of that. And we've made a lot of changes to git cl upload that I think should have helped with this. But if you're still having issues please let me know.

Sign in to add a comment