New issue
Advanced search Search tips

Issue 838335 link

Starred by 2 users
Status: Fixed
Owner:
ajp@chromium.org
Closed: Dec 18
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Previous locations:
gerrit:8821


Sign in to add a comment

Flaky HTTP responses when uploading

Project Member Reported by gab@chromium.org, Apr 23 2018 
OS: Win10

I used to hit this occasionally, but running git cl split today (split into 110CLs) I hit this ~5 times in 110 uploads (git cl split breaksdown when this happens)

remote: Processing changes: new: 1, done
remote: (W) 5f65920: commit subject >50 characters; use shorter first paragraph
remote:
remote: New Changes:
remote:   https://chromium-review.googlesource.com/#/c/chromium/src/+/1024378 Migrate MessageLoop::current() to MessageL
oopCurrent in /mojo
remote:
To https://chromium.googlesource.com/chromium/src.git
 * [new branch]                5f65920ccceadc55f20ef1c7735388268faac11b -> refs/for/refs/heads/master%ready,notify=ALL,m
=Initial_upload,hashtag=migrate-messageloop
[W2018-04-23 14:59:35,124 22036 23496 gerrit_util.py] A transient error occurred while querying chromium-review.googleso
urce.com:
POST https://chromium-review.googlesource.com/a/changes/1024378/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-23 14:59:36,239 22036 23496 gerrit_util.py] A transient error occurred while querying chromium-review.googleso
urce.com:
POST https://chromium-review.googlesource.com/a/changes/1024378/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-23 14:59:38,411 22036 23496 gerrit_util.py] A transient error occurred while querying chromium-review.googleso
urce.com:
POST https://chromium-review.googlesource.com/a/changes/1024378/revisions/current/review HTTP/1.1
HTTP/1.1 500 Internal Server Error
[W2018-04-23 14:59:42,512 22036 23496 gerrit_util.py] A transient error occurred while querying chromium-review.googleso
urce.com:
POST https://chromium-review.googlesource.com/a/changes/1024378/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-23 14:59:50,634 22036 23496 gerrit_util.py] A transient error occurred while querying chromium-review.googleso
urce.com:
POST https://chromium-review.googlesource.com/a/changes/1024378/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
[W2018-04-23 15:00:06,733 22036 23496 gerrit_util.py] A transient error occurred while querying chromium-review.googleso
urce.com:
POST https://chromium-review.googlesource.com/a/changes/1024378/revisions/current/review HTTP/1.1
HTTP/1.1 404 Not Found
Traceback (most recent call last):
  File "D:\src\depot_tools\\git_cl.py", line 6038, in <module>
    sys.exit(main(sys.argv[1:]))
  File "D:\src\depot_tools\\git_cl.py", line 6020, in main
    return dispatcher.execute(OptionParser(), argv)
  File "D:\src\depot_tools\subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "D:\src\depot_tools\\git_cl.py", line 5088, in CMDsplit
    Changelist, WrappedCMDupload, options.dry_run)
  File "D:\src\depot_tools\split_cl.py", line 215, in SplitCl
    description, comment, reviewers, changelist, cmd_upload)
  File "D:\src\depot_tools\split_cl.py", line 114, in UploadCl
    cmd_upload(upload_args)
  File "D:\src\depot_tools\\git_cl.py", line 5085, in WrappedCMDupload
    return CMDupload(OptionParser(), args)
  File "D:\src\depot_tools\\git_cl.py", line 5058, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "D:\src\depot_tools\\git_cl.py", line 1618, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
  File "D:\src\depot_tools\\git_cl.py", line 3121, in CMDUploadChange
    notify=bool(options.send_mail))
  File "D:\src\depot_tools\gerrit_util.py", line 722, in AddReviewers
    resp = ReadHttpJsonResponse(conn, accept_statuses=accept_statuses)
  File "D:\src\depot_tools\gerrit_util.py", line 432, in ReadHttpJsonResponse
    fh = ReadHttpResponse(conn, accept_statuses)
  File "D:\src\depot_tools\gerrit_util.py", line 426, in ReadHttpResponse
    raise GerritError(response.status, reason)

Comment 1 by gab@chromium.org, Apr 23 2018

Description: Show this description

Comment 2 by gab@chromium.org, Apr 23 2018 

Note: running "git cl owners" after this results in 

D:\src\chrome\src>git cl owners
Traceback (most recent call last):
  File "D:\src\depot_tools\\git_cl.py", line 6038, in <module>
    sys.exit(main(sys.argv[1:]))
  File "D:\src\depot_tools\\git_cl.py", line 6020, in main
    return dispatcher.execute(OptionParser(), argv)
  File "D:\src\depot_tools\subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "D:\src\depot_tools\\git_cl.py", line 5716, in CMDowners
    cl.GetReviewers(),
  File "D:\src\depot_tools\\git_cl.py", line 1739, in GetReviewers
    return self._codereview_impl.GetReviewers()
  File "D:\src\depot_tools\\git_cl.py", line 3273, in GetReviewers
    return [reviewer['email'] for reviewer in details['reviewers']['REVIEWER']]
KeyError: 'REVIEWER'


(whereas usually it works -- git cl upload is specifying -r on command-line with git cl split... related?)

Comment 3 by logan@google.com, Apr 30 2018

Project: chromium
Moved issue gerrit:8821 to now be  issue chromium:838335 .

Comment 4 by logan@google.com, Apr 30 2018

Components: Infra>Codereview>Gerrit
Labels: -Priority-3

Comment 5 by ajp@chromium.org, Dec 18

Labels: Pri-2
Owner: ajp@chromium.org
Status: Fixed (was: New)
The root of this problem, replication delay, is still around. But we've substantially rewritten git cl upload to not make these HTTP requests during upload. I believe this issue should be fixed by existing work to address bug 881860. Please re-open if you're still seeing issues.
►

Sign in to add a comment