New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838329 link

Starred by 1 user
Status: Fixed
Owner:
jkardatzke@chromium.org
Closed: May 2018
Cc:
nverne@chromium.org
timzheng@chromium.org
timloh@chromium.org
█ reve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Android Studio setup dialog doesn't have an icon in shelf

Project Member Reported by tbuck...@chromium.org, Apr 30 2018 
Chrome version: 68.0.3415.0 canary
OS: Chrome

Repro steps:
1. Unzip android_studio.zip
2. Run ./android_studio/bin/studio.sh for first time

Expected: Penguin icon in shelf (since Android Studio doesn't have a .desktop file)
Actual: No icon in shelf for the open windows
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bd68cfe9f62157eb2c9dfb67d1d4c4387c307f05

commit bd68cfe9f62157eb2c9dfb67d1d4c4387c307f05
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Tue May 01 20:06:49 2018

vm_tools: Fixed loading icons with absolute paths

The code was checking for "png" for the file extension when it should
have been checking for ".png".

BUG= chromium:838329 
TEST=Verified Android Studio icon loads (it uses an absolute path)

Change-Id: Icc902b8bafaa22b6ad3b13fe94b87e0e4037547b
Reviewed-on: https://chromium-review.googlesource.com/1036195
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/bd68cfe9f62157eb2c9dfb67d1d4c4387c307f05/vm_tools/garcon/icon_finder.cc

Comment 2 by jkardatzke@chromium.org, May 1 2018

Status: Fixed (was: Assigned)

Comment 3 by vapier@chromium.org, May 9 2018

Components: OS>Systems>Containers

Comment 4 by vapier@chromium.org, May 17 2018

Labels: -Restrict-View-Google
►

Sign in to add a comment