[Findit] Flake Analyzer - Break data_point_util.py's UpdateAnalysisDataPoints into separate functions |
||
Issue descriptionDue to updating data points being transactional, several underlying functions won't work. e.g. getting swarming settings uses config which is versioned, but versioning doesn't work with transactional. UpdateAnalysisDataPoints should be broken into separate functions: 1. a function that gathers data (build info, swarming task output, etc) 2. a function that puts the data together to create a data point and append it to a MasterFlakeAnalysis
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8e8b2824177f0e469d7c42c5cb7a3cbed42f7f58 commit 8e8b2824177f0e469d7c42c5cb7a3cbed42f7f58 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Wed May 02 19:32:02 2018 [Findit] Flake Analyzer - Removing transactional from updating data points There is no need for this function to be transactional, which is also causing trouble. @transactional is to guard against multiple analyses trying to write to the same ndb entity. In the case of Flake Analyzer, there is only 1 active analysis for a given flaky test at a time, thus @transactional provides no benefit. In the existing code when populating data with build level information, step_util relies on wf_config, which asserts the calling code cannot be in a transaction, causing this function to fail. A follow-up CL not to retrieve build-level information here will come shortly. Bug: 838326 Change-Id: I6d6a1d26d3d8cd816a1d4dd5edf1d585ec9379cf Reviewed-on: https://chromium-review.googlesource.com/1040270 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/8e8b2824177f0e469d7c42c5cb7a3cbed42f7f58/appengine/findit/services/flake_failure/data_point_util.py
,
May 3 2018
per discussion build info won't be used in this function any longer. |
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Apr 30 2018