New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838308 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 658300
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

CachedMetrics and RecordHistograms/UserActions should be unified

Project Member Reported by mariakho...@chromium.org, Apr 30 2018

Issue description

This came out of discussion Dmitry and I were having today:

Today there's some code in early startup that records metrics by using the CachedMetrics mechanism, where the metrics are kept in Java memory until native is initialized and then recorded. Other instances of code, just check for LibraryLoader.isInitialized() and omit recording metrics in code if native isn't loaded yet. On top of it, cached metrics in child processes (e.g. renderer) don't get recorded at all because the record signal is tied to activity signals.

What we should probably have instead is a RecordMetrics abstraction that does the right thing under the hood:
- caches in java if native is not yet loaded
- uses better signals to learn when it's safe to record the metrics
- records native metrics as today when native is loaded
 
Mergedinto: 658300
Status: Duplicate (was: Available)
Agree that would be nice. We have an existing bug about this, merging. I'll paste your description so it doesn't get lost.

Sign in to add a comment