Close ArcExternalProtocolDialog auth tabs |
||||||
Issue descriptionThis partially mirrors b/71916202 Authentication process 1 Via Google Assistant the user tries to login to an app 2 The user is send to Chrome to validate their credentials 3 After completion the user is presented with the option to go back to ARC (via the picker) 4 The tab for the credentials input is left behind, which may be confusing This bug is for closing tabs left behind in 4)
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a242af0746e1d24e778692cffdaeb07821dd2527 commit a242af0746e1d24e778692cffdaeb07821dd2527 Author: David Jacobo <djacobo@chromium.org> Date: Sat May 12 04:42:06 2018 Close ArcExternalProtocolDialog auth tabs Automatically close tabs after the user is authenticated and redirected to an ARC app. ArcWebContentsData can be removed via ArcExternalProtocolDialog as well as in AppsNavigationThrottle, with this we try to reduce the scope of the flag as much as possible while still allowing the user to bypass the UI and automatically close tabs left behind in the process. Bug: 838294 Test: Build, unit_tests still works Change-Id: Ifb812a3fab2fe7f49f07b4fbaee754ac96ea158f Reviewed-on: https://chromium-review.googlesource.com/1026870 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558113} [modify] https://crrev.com/a242af0746e1d24e778692cffdaeb07821dd2527/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
,
May 14 2018
I don't consider this blocking but its a good improvement for user's UX, it only affects Chrome OS users. Tested in Cros 10675.0.0
,
May 14 2018
+ kbleicher@ (Chrome OS M67 Release TPM) for merge review
,
May 14 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2018
This request is coming in a bit late for M67. I'm tempted to reject per #3 (not blocking and a UX issue). Also not clear this was introduced in M67.
,
May 16 2018
I synced with my TL and yeah I think we can live without these on M67 :) thanks!
,
May 16 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by djacobo@chromium.org
, Apr 30 2018