New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838291 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 894835



Sign in to add a comment

Make headless chrome work with network service

Project Member Reported by caseq@chromium.org, Apr 30 2018

Issue description

Headless currently exposes some interfaces that rely on legacy chrome network implementation (this includes invocation of some client callbacks on IO thread). We need to make headless work with the network service, and the consumers should be switched to rely on DevTools protocol rather than on headless-specific native API.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee045a5ae4784d9223b1152db737f40c93a385da

commit ee045a5ae4784d9223b1152db737f40c93a385da
Author: Johannes Henkel <johannes@chromium.org>
Date: Sat May 12 03:45:14 2018

ResourceRequestBlockedReason: use base::Optional instead of kNone value.

This change will make it easier to finish
https://chromium-review.googlesource.com/c/chromium/src/+/1035091:
- The "other" blocked reason, that is, an unspecified blocked reason,
  is now the default which we'll assume for the 0 value.
- There's a 1:1 correspondence with the enum in
  browser_protocol.pdl, so we no longer need to conflate kNone and
  kOther.
- The base::nullopt value for base::Optional<...> is more appropriate
  because in the inspector's protocol it will correspond to the absence
  of a string value (e.g. in a JSON message), as opposed to the string
  "none" or "other" (both misleading).
Would like to land this first since it's easier to review / test it
this way, as opposed to mixing it into a larger PR.

Bug:  838291 
Change-Id: I66da523495b38a297d22289ae7c32367a66bd6bb
Reviewed-on: https://chromium-review.googlesource.com/1056030
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558109}
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/platform/loader/fetch/resource_request.h
[modify] https://crrev.com/ee045a5ae4784d9223b1152db737f40c93a385da/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c588c23a3d58e71f78cfe5f0d201404bfbf5a9

commit d4c588c23a3d58e71f78cfe5f0d201404bfbf5a9
Author: Johannes Henkel <johannes@chromium.org>
Date: Mon May 14 22:54:09 2018

Move blink::ResourceRequestBlockedReason into web_url_error.h.

This takes care of a mechanical part of
https://chromium-review.googlesource.com/c/chromium/src/+/1035091.
web_url_error.h is a public header file, so it's possible to then
depend on this.

Bug:  838291 
Change-Id: Ib7dfb28094466661e0aa5e28a94926b923dbbf1f
Reviewed-on: https://chromium-review.googlesource.com/1057950
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558503}
[modify] https://crrev.com/d4c588c23a3d58e71f78cfe5f0d201404bfbf5a9/third_party/blink/public/platform/web_url_error.h
[modify] https://crrev.com/d4c588c23a3d58e71f78cfe5f0d201404bfbf5a9/third_party/blink/renderer/platform/loader/fetch/resource_request.h

Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b22b7249613509c86204dab2c02e51261b661e

commit 98b22b7249613509c86204dab2c02e51261b661e
Author: Johannes Henkel <johannes@chromium.org>
Date: Tue May 15 22:25:06 2018

Move ResourceRequestBlockedReason into its own header.

As suggested in
https://chromium-review.googlesource.com/c/chromium/src/+/1035091
since we'll need to add this to content/browser/DEPS and the
WebURLError class isnt' a good fit for this.

Bug:  838291 
Change-Id: I95491371a70fa4d765328b25d89f0a69149cc071
Reviewed-on: https://chromium-review.googlesource.com/1060111
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558861}
[add] https://crrev.com/98b22b7249613509c86204dab2c02e51261b661e/third_party/blink/public/platform/resource_request_blocked_reason.h
[modify] https://crrev.com/98b22b7249613509c86204dab2c02e51261b661e/third_party/blink/public/platform/web_url_error.h
[modify] https://crrev.com/98b22b7249613509c86204dab2c02e51261b661e/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
[modify] https://crrev.com/98b22b7249613509c86204dab2c02e51261b661e/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/98b22b7249613509c86204dab2c02e51261b661e/third_party/blink/renderer/platform/loader/fetch/resource_error.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c748e7017df4e8ac875cda0aa94d34471973c7b6

commit c748e7017df4e8ac875cda0aa94d34471973c7b6
Author: Johannes Henkel <johannes@chromium.org>
Date: Wed May 16 03:00:22 2018

Add BlockedByClient and BlockedByResponse to Network::ErrorReason enum.

This is a chiseled out part of
https://chromium-review.googlesource.com/c/chromium/src/+/1035091,
which allows observation of blocked by client requests, including
those caused by interception via the devtools protocol.
While I'm at this, I'm changing NetErrorToString to a switch.

Bug:  838291 
Change-Id: I7741e7b453251ee0f9995563999cf14a4707eb34
Reviewed-on: https://chromium-review.googlesource.com/1060518
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558948}
[modify] https://crrev.com/c748e7017df4e8ac875cda0aa94d34471973c7b6/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/c748e7017df4e8ac875cda0aa94d34471973c7b6/third_party/blink/renderer/core/inspector/browser_protocol.pdl

Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515

commit 6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515
Author: Johannes Henkel <johannes@chromium.org>
Date: Thu May 17 18:41:52 2018

Support network::ErrorReason::BLOCKED_BY_CLIENT for inspector with network service enabled.

This change makes it so that when client code of the devtools protocol sets the
particular ErrorReason BLOCKED_BY_CLIENT, we capture that it's devtools
(also known as inspector int he code) which blocked the request. We then make
this available via the devtools protocol also that the client may distinguish
resource loads blocked by this particular reason.

Bug:  838291 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id3b4b9b96ae15f31cb1170d5d6e028b6da05affe
Reviewed-on: https://chromium-review.googlesource.com/1035091
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559623}
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/DEPS
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/public/browser/resource_request_info.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/test/test_navigation_url_loader_delegate.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/content/test/test_navigation_url_loader_delegate.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/third_party/blink/renderer/platform/loader/fetch/resource_error.cc
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/third_party/blink/renderer/platform/loader/fetch/resource_error.h
[modify] https://crrev.com/6a43fef57f9bf8bfcfaf5a9b3847e8f53a125515/third_party/blink/renderer/platform/loader/fetch/resource_request.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd60610885a0431bda63b46b8abedc09a9dfcc80

commit cd60610885a0431bda63b46b8abedc09a9dfcc80
Author: Johannes Henkel <johannes@chromium.org>
Date: Mon May 21 22:06:23 2018

Starting point for porting BlockedByClient_NetworkObserver_Test to LayoutTests.

This test is currently in
headless/lib/headless_devtools_client_browsertests.cc.
I'm working on porting it to Javascript for easier maintenance.
This PR doesn't cover the entire test yet, so I'll follow up with
  more but figure it'd be good to check in a snapshot to begin with.

Bug:  838291 
Change-Id: I647e0fef263adde129f7c12d48283708a4e84ca0
Reviewed-on: https://chromium-review.googlesource.com/1066940
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560371}
[add] https://crrev.com/cd60610885a0431bda63b46b8abedc09a9dfcc80/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/blocked-by-client-network-observer-expected.txt
[add] https://crrev.com/cd60610885a0431bda63b46b8abedc09a9dfcc80/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/blocked-by-client-network-observer.js
[add] https://crrev.com/cd60610885a0431bda63b46b8abedc09a9dfcc80/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/page-with-subresource.html

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01

commit b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Oct 03 04:17:27 2018

Do not expose host resolver options in HeadlessBrowserContext

... just use the command line switch instead. This is one of a steps to
prepare for the network service migration -- network service
does not expose an interface other than command line flag to configure
resolver, so we could as well let it interpret the flag directly.

Bug:  838291 
Change-Id: I249beb1b64a0b5f332a1f2fa43325af2c4c0a6b6
Reviewed-on: https://chromium-review.googlesource.com/c/1258326
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596120}
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/app/headless_shell.cc
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/lib/browser/headless_browser_context_options.cc
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/lib/browser/headless_browser_context_options.h
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/lib/browser/headless_url_request_context_getter.h
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/public/headless_browser.cc
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/public/headless_browser.h
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/public/headless_browser_context.h
[modify] https://crrev.com/b276e5ed2a3f2a5d6c129d062490b3dcbe4acd01/headless/test/headless_protocol_browsertest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac

commit 1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Oct 11 19:40:33 2018

Support network service in headless

- extract all URLRequestContextGettter and NetworkContext creation logic into HeadlessRequestContextManager;
- reconcile network service and non-network service code paths as much as possible;
- fix a couple of issues with handling of redirect URLs in DevToolsURLLoaderInterceptor that
    were different from URLRequestJob-based interception and caused headless tests to fail;
- plumb a call to NetworkServiceTestHelper::RegisterNetworkBinders() in headless utility
    process when running tests to let network service tests inject the magic client certificates;
- update traffic annotations as they just moved;

Bug:  838291 , 792676 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia29143a85b0c0293fae13079ec9f88ff5ba924f9
Reviewed-on: https://chromium-review.googlesource.com/c/1263566
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598893}
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/BUILD.gn
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/DEPS
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_browser_context_impl.h
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_browser_impl.h
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_content_browser_client.h
[add] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_request_context_manager.cc
[add] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/browser/headless_request_context_manager.h
[delete] https://crrev.com/2863ae23721602d503a4a553659481deb2df15a1/headless/lib/browser/headless_url_request_context_getter.cc
[delete] https://crrev.com/2863ae23721602d503a4a553659481deb2df15a1/headless/lib/browser/headless_url_request_context_getter.h
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/utility/headless_content_utility_client.cc
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/lib/utility/headless_content_utility_client.h
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/test/data/protocol/helpers/http-interceptor.js
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/headless/test/headless_test_launcher.cc
[modify] https://crrev.com/1ca23fca21d3b83ee0d03cf1c6c011bdc3fb9fac/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed8c927801fdf271cff29cb95a46546cef0a9239

commit ed8c927801fdf271cff29cb95a46546cef0a9239
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Fri Oct 12 09:11:23 2018

[jumbo] fixup after recent headless network service work

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1263566
which introduced a namespace clash between ::network and ::headless::network.

Also, rename one of two kProductName's.

TBR=caseq@chromium.org

Bug:  838291 , 792676 
Change-Id: Ie1fc9ab2096a09651ba2dd45aa262ab30bfd3efc
Reviewed-on: https://chromium-review.googlesource.com/c/1277992
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599150}
[modify] https://crrev.com/ed8c927801fdf271cff29cb95a46546cef0a9239/headless/lib/browser/headless_request_context_manager.cc
[modify] https://crrev.com/ed8c927801fdf271cff29cb95a46546cef0a9239/headless/public/headless_browser.cc

Blockedon: 894835
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32b7e250285e3df8be8ccbb8f00c1054e94f1cae

commit 32b7e250285e3df8be8ccbb8f00c1054e94f1cae
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Sat Oct 13 01:01:46 2018

Add headless_browsertests with --enable-features=NetworkService

Bug:  838291 
Change-Id: I02f10d1ab707f5012a56c2dc805b86ee0c0537cf
Reviewed-on: https://chromium-review.googlesource.com/c/1278994
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599454}
[modify] https://crrev.com/32b7e250285e3df8be8ccbb8f00c1054e94f1cae/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/32b7e250285e3df8be8ccbb8f00c1054e94f1cae/testing/buildbot/test_suites.pyl

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 17

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7

commit 1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Wed Oct 17 18:13:22 2018

[jumbo] fixup after recent headless network service work

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1263566
which introduced a namespace clash between ::network and ::headless::network.

Also, rename one of two kProductName's.

TBR=caseq@chromium.org

Bug:  838291 , 792676 
Change-Id: Ie1fc9ab2096a09651ba2dd45aa262ab30bfd3efc
Reviewed-on: https://chromium-review.googlesource.com/c/1277992
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599150}(cherry picked from commit ed8c927801fdf271cff29cb95a46546cef0a9239)
Reviewed-on: https://chromium-review.googlesource.com/c/1286663
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/branch-heads/3578@{#91}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7/headless/lib/browser/headless_request_context_manager.cc
[modify] https://crrev.com/1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7/headless/public/headless_browser.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1381120f746b25c52b531e8763bc46a1b31513e6

commit 1381120f746b25c52b531e8763bc46a1b31513e6
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Oct 18 21:10:10 2018

DevTools: support cookies in URLLoader-based network interceptor

Bug:  850689 , 838291 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I4017d89466de05936b697385436e6519934a9f19
Reviewed-on: https://chromium-review.googlesource.com/c/1282443
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600907}
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-patterns.js
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/url-fragment-expected.txt
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/url-fragment.js

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7

Commit: 1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7
Author: mostynb@vewd.com
Commiter: mostynb@vewd.com
Date: 2018-10-17 18:13:22 +0000 UTC

[jumbo] fixup after recent headless network service work

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1263566
which introduced a namespace clash between ::network and ::headless::network.

Also, rename one of two kProductName's.

TBR=caseq@chromium.org

Bug:  838291 , 792676 
Change-Id: Ie1fc9ab2096a09651ba2dd45aa262ab30bfd3efc
Reviewed-on: https://chromium-review.googlesource.com/c/1277992
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599150}(cherry picked from commit ed8c927801fdf271cff29cb95a46546cef0a9239)
Reviewed-on: https://chromium-review.googlesource.com/c/1286663
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/branch-heads/3578@{#91}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Assigned)

Sign in to add a comment