New issue
Advanced search Search tips

Issue 838290 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

MD-Extensions: unneeded scrollbar in details page

Reported by woxxom@gmail.com, Apr 30 2018

Issue description

Chrome 65, 66, 67, 68

==================================

1. install at least one extension, for example the attached one
2. open material chrome://extensions
   (see the note below)
3. maximize the window
4. click any extension's "Details" button

Expected: no scrollbar
Observed: scrollbar

Note: in older Chrome you might need to force MD-Extensions via chrome://flags/#enable-md-extensions
or command line switch "--enable-features=MaterialDesignExtensions"

==================================

Bisected to 6afebb399ed68da125de48025d5476b3baa2638e = https://crrev.com/c/841533 by dpapad@chromium.org
"MD Extensions polish: Add bottom padding in details page"

==================================

This happens because the padding added in this CL is summed with "min-height: 100%;" so the resultant height is "100% + 64px".
The bug can/should be fixed by adding "box-sizing: border-box;"

 
test-ext.zip
326 bytes Download
good.png
56.7 KB View Download
bad.png
54.5 KB View Download

Comment 1 by dpa...@chromium.org, Apr 30 2018

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Still an issue.

Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
Candidate fix https://chromium-review.googlesource.com/c/chromium/src/+/1305202.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d6e5c4e91720211936ab288dad5bae9661b983

commit 51d6e5c4e91720211936ab288dad5bae9661b983
Author: dpapad <dpapad@chromium.org>
Date: Tue Oct 30 00:16:45 2018

Extensions WebUI: Remove unnecessary white space in detail view.

Bug:  838290 
Change-Id: I60e56e959e22a67018d200f8158e837ec8e9a3c8
Reviewed-on: https://chromium-review.googlesource.com/c/1305202
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603699}
[modify] https://crrev.com/51d6e5c4e91720211936ab288dad5bae9661b983/chrome/browser/resources/md_extensions/detail_view.html

Status: Fixed (was: Started)
Cc: phanindra.mandapaka@chromium.org
Labels: Needs-Feedback
Tried verifying the fix on build without fix #68.0.3420.0 and build with fix #72.0.3596.0 on Ubuntu 17.10, Mac 10.14.0, 10.13.6 and Windows 10 by following steps as per comment #0, but unable to observe the difference between the both builds on Ubuntu and Mac. 
Observation: Scroll bar observed on Mac and Ubuntu and not seen on Windows 10 on latest chrome 72.0.3596.0
Attached the screen-cast for reference.
dpapad@ - Could you please help in verifying the fix.

Thanks..!

838290.PNG
100 KB View Download
828390.png
56.0 KB View Download

Sign in to add a comment