New issue
Advanced search Search tips

Issue 838260 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Save as dialog can get forced in popup and renders cut off

Reported by peter.m....@gmail.com, Apr 30 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce the problem:
1. Clone this repo and install as unpacked extension: https://github.com/mrcoles/test-chrome-extension-downloadinpopup
2. Click on its icon and a download and work fine
3. Go to Chrome > Preferences > Advanced > Downloads and enable “Ask where to save each file before downloading”
4. Click on the extension icon again, this time a save as window appears that gets pulled partially off screen.

What is the expected behavior?
Either the `saveAs: false` setting should override this advanced preference or the save as dialog should not get pulled off screen.

What went wrong?
I was presented with a save as dialog screen that got pulled off the screen.

See the attached image. Interestingly enough screenshotting it with cmd + shift + 4 + spacebar created a larger image than what was visible on my laptop screen that included the cut off dialog.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 66.0.3359.117  Channel: n/a
OS Version: OS X 10.13.2
Flash Version:
 
Screen Shot 2018-04-30 at 1.09.35 PM.png
1.0 MB View Download
Additionally, is there any way for an extension to tell if the “Ask where to save each file before downloading” feature is enabled or not?

Comment 2 by sdy@chromium.org, May 1 2018

Components: Platform>Extensions
Labels: Needs-Triage-M66
Labels: Triaged-ET M-68 FoundIn-68 Target-68
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.13.3 using chrome latest stable #66.0.3359.139 and latest canary #68.0.3418.0. Issue is not seen in OS-linux and OS-win.
This is a non-regression issue as it is observed from M60 old builds. 

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!
Components: -Platform>Extensions UI>Browser>Downloads
Passing to downloads triage queue, since this seems like an issue in that API.
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
[mac bug triage] Assigning to sdy@ to have a look
@5 - is there any way for an extension to tell in JS code if the “Ask where to save each file before downloading” feature is enabled in Chrome or not?
Also, if you trigger two or more downloads when this setting is enabled, the open dialog window of the first download will cancel the other downloads and leave them as zombie downloads (that even show up in the Chrome icon until you restart Chrome).

I’d *love* to hear if there’s any way to detect that this setting is enabled. Then, if it’s not getting fixed, I could at least communicate expectations to people :D

Screen Shot 2018-08-06 at 4.13.35 PM.png
20.0 KB View Download

Sign in to add a comment