New issue
Advanced search Search tips

Issue 838258 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Fix ChromePath of enterprise reporting extension API

Project Member Reported by zmin@chromium.org, Apr 30 2018

Issue description

This path currently contains version information on Windows. It causes identity issue on the server side. As Chrome upgrade will create a new Chrome instance record on the DM Server.
 

Comment 2 by zmin@chromium.org, Apr 30 2018

Labels: Merge-Request-67
I'd like to merge the CL:

The CL resolved an important issue for token based cloud policy which will be tested by trust testers in M67.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 30 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Apr 30 2018

How is this change - http://crrev.com/85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b  looking in canary? Is it safe to merge?
@4

I just manually tested it, fix works. And it's completely safe (this does not affect normal users, only for our team's testing).

Thanks.

Comment 6 by gov...@chromium.org, Apr 30 2018

Labels: -Merge-Review-67 Merge-Approved-67
Approving merge for CL - http://crrev.com/85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b  to M67 branch 3396 based on comment #5. Please merge ASAP so we can pick it up for this week M67 beta release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 30 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab6e8fd876bdce7db0cabf06bd74ab5f44d65d0d

commit ab6e8fd876bdce7db0cabf06bd74ab5f44d65d0d
Author: Owen Min <zmin@chromium.org>
Date: Mon Apr 30 18:30:34 2018

Merge "Update ChromePath in enterprise reporting private API" to M67.

Using base::DIR_EXE to replace DIR_APP. Because the first one does not
contain version info in the path. And it also providers a meaningful path
on Mac and Linux.

TBR=zmin@chromium.org

(cherry picked from commit 85dffcbf7c2ce7d9207c5489ac4d0d01f9326e3b)

Bug:  838258 
Change-Id: I686a5c2f14b62b7f0d4789eeb88f031793d57b22
Reviewed-on: https://chromium-review.googlesource.com/1030878
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554387}
Reviewed-on: https://chromium-review.googlesource.com/1035723
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#388}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ab6e8fd876bdce7db0cabf06bd74ab5f44d65d0d/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc

Comment 8 by zmin@chromium.org, May 11 2018

Status: Verified (was: Started)

Sign in to add a comment