New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838251 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Flake-Analyzer] BadRequestError: cross-group transaction need to be explicitly specified, see TransactionOptions.Builder.withXG

Project Member Reported by chanli@chromium.org, Apr 30 2018

Issue description

Error log: https://pantheon.corp.google.com/logs/viewer?project=findit-for-me&key1=default&key2=alpha&minLogLevel=0&expandAll=false&timestamp=2018-04-30T16:49:55.742000000Z&customFacets=&limitCustomFacetWidth=true&dateRangeStart=2018-04-23T16:49:55.993Z&dateRangeEnd=2018-04-30T16:49:55.993Z&interval=P7D&resource=gae_app%2Fmodule_id%2Fwaterfall-backend%2Fversion_id%2F15192-6d645d6&logName=projects%2Ffindit-for-me%2Flogs%2Fappengine.googleapis.com%252Frequest_log&filters=text:%22cross-group%20transaction%20need%20to%20be%20explicitly%20specified%22&scrollTimestamp=2018-04-27T23:39:05.399925000Z

Most important traceback:
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:15192-6d645d6.409329331433507053/services/flake_failure/data_point_util.py", line 181, in UpdateAnalysisDataPoints
    analysis.build_number, commit_position)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:15192-6d645d6.409329331433507053/services/step_util.py", line 112, in GetValidBoundingBuildsForStep
    upper_bound_build_number)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:15192-6d645d6.409329331433507053/waterfall/build_util.py", line 103, in GetBuildInfo
    build_number)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:15192-6d645d6.409329331433507053/waterfall/build_util.py", line 67, in DownloadBuildData
    build = WfBuild.Get(master_name, builder_name, build_number)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:15192-6d645d6.409329331433507053/model/wf_build.py", line 29, in Get
    return WfBuild._CreateKey(master_name, builder_name, build_number).get()

UpdateAnalysisDataPoints is in a transaction, so getting WfBuild caused cross-group transaction error.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/47db0e141fef9045d129b405b358fa8a57c27085

commit 47db0e141fef9045d129b405b358fa8a57c27085
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Apr 30 18:24:41 2018

[Findit[ Flake Analyzer - Speculative fix for updating data points failing cross-group transactions

Bug:  838251 
Change-Id: I399d22438c1aad7ab6e9a4cab6d3e9128e952fbb
Reviewed-on: https://chromium-review.googlesource.com/1035609
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/47db0e141fef9045d129b405b358fa8a57c27085/appengine/findit/services/flake_failure/data_point_util.py

Status: Fixed (was: Assigned)

Sign in to add a comment