New issue
Advanced search Search tips

Issue 838166 link

Starred by 11 users

Issue metadata

Status: Duplicate
Merged: issue 881694
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Trivial subdomain elision should elide only from the left

Project Member Reported by elawrence@chromium.org, Apr 30 2018

Issue description

Chrome Version       : 68.0.3415.0
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:

What steps will reproduce the problem?
1. Enable chrome://flags/#omnibox-ui-hide-steady-state-url-scheme-and-subdomains
2. Load a page like https://www.m.www.example.www.m.com/

Expect: Omnibox shows "example.www.m.com"
Actual: Omnibox shows "example.m.com".

https://cs.chromium.org/chromium/src/components/url_formatter/url_formatter.cc?l=80&rcl=61966fae44c696eed8c1735e920da0e3ddd6f475
 
ElidesMiddle.png
22.0 KB View Download
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Status: WontFix (was: Assigned)
Hmm. This is interesting.

We specifically don't only elide from the left, because we wanted to elide:

en.m.wikipedia.org to simply en.wikipedia.org. The report in #0 is essentially working as intended.

We could add a more complicated heuristic, but unless it's a "big deal", I'd favor leaving the current simple logic alone.

I'm marking WONTFIX tentatively, but let's continue the discussion -- especially if anyone has strong feelings.
This really does feel weird/wrong to me, but Emily is probably the decider here.
Mergedinto: 881410
Status: Duplicate (was: WontFix)
Apparently, conversation continues in  Issue 881410 .
Mergedinto: -881410 881694
I don't suppose there's a way for the general public to follow the progress of this? The security bug is not public, which seems very odd given the nature of the problem (everyone uses URLs, this is not Chrome-specific).
I'd like to second comment 7's question, and ask further, where we should send feedback on this change? I doubt you want it all in the issue tracker, especially since it appears most if not all conversation on the subject has been merged into that private-marked security issue.

Comment 9 Deleted

Shameful.
 Bug 881694  shows as 'does not exist' for me, so I assume it's marked private.

Where do we send feedback on this URL change?  I think the Chromium team is seriously overstepping its bounds here in ways that actually make the way the way the web works much LESS transparent.

I'm really getting tired of these edicted changes in blog posts with 0 opportunity to comment that get implemented 3 months later and break a ton of things, often in ways that benefit Google over the multitude of smaller voices that are present on the web.

I've stopped recommending Chrome to friends and family.
I think what it comes down to is aligning how Chrome behaves with web design best practices.  I believe that making "www.example.com" and "example.com" point to materially-different content is a mistake, so Chrome hiding that is a reasonable step -- obviously from the discussion in 881410 this is a matter of some contention.  I think there's room for reasonable people to disagree about telling the user they're on "m.example.com".

I also think that it's opening a pretty big can of worms to suggest that hiding the "m." in "en.m.wikipedia.org" is somehow helpful but hiding the "en." isn't -- after all, I'm looking at the page content, it's in English, why tell me in the URL bar?  Why not make all 2-character ISO language abbreviations part of the "trivial subdomains" list?  After all, if I'm on "de.whatever.com", the fact that it's in German (or the page of the comapny's German subsidiary) is probably readily apparent.  If you start down that road, where does it end?
Labels: Restrict-AddIssueComment-EditIssue
We've already gotten substantial feedback on this feature. The security bug is restricted while we discuss security implications and response.

Sign in to add a comment