New issue
Advanced search Search tips

Issue 838150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 823365



Sign in to add a comment

extension popup auto-scrollbar feedback loop

Reported by amiag...@gmail.com, Apr 30 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Launch Chrome using the Italian locale
2. Install Privacy Badger (https://eff.org/pb)
3. Visit a site with lots of third-party domains (nytimes.com) and click on Privacy Badger's browser popup

What is the expected behavior?
The popup displays a list of third-party domains.

What went wrong?
The popup flickers/jumps around endlessly. This does not happen in Firefox.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 66.0.3359.139  Channel: n/a
OS Version: 
Flash Version: 

See the following Privacy Badger GitHub issue for more information: https://github.com/EFForg/privacybadger/issues/1977#issuecomment-383621291.
 
Labels: Needs-Triage-M66
Components: UI>Browser
Labels: Needs-Bisect

Comment 3 by amiag...@gmail.com, May 7 2018

We are going to work around this on our end in the next Privacy Badger update. Here is a direct link to the as-of-now current version CRX that will continue exhibiting this Chrome rendering bug in the Italian locale: https://www.eff.org/files/privacy_badger-2018.4.23.crx
Components: Blink>Scroll
Labels: -Type-Bug -Pri-2 -Needs-Bisect ReleaseBlock-Stable Target-67 Triaged-ET Target-66 M-66 M-67 FoundIn-66 FoundIn-67 FoundIn-68 Target-68 RegressedIn-66 hasbisect OS-Windows Pri-1 Type-Bug-Regression
Owner: skobes@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 and Ubuntu 14.04 using chrome reported version #66.0.3359.139 and latest canary #68.0.3423.2. Issue is not seen in OS-mac.

Bisect Information:
=====================
Good build: 66.0.3344.0
Bad Build : 66.0.3345.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/43e31b80075135d513ff10a19e8293aca21a0ed0..004f3b4b4000be325307d1c409a03411aa00beaa

From the above change log suspecting below change
Change-Id: I7db52fb701bee9b017bebc70b777255601250d3a
Reviewed-on: https://chromium-review.googlesource.com/857902

skobes@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-66 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!
Labels: -ReleaseBlock-Stable
Status: Started (was: Assigned)
Removing RBS since M66 has already shipped.
Blocking: 823365

Comment 7 by amiag...@gmail.com, May 31 2018

Here is another user report (Chromium Version 66.0.3359.170 (Official Build) Arch Linux (64-bit)), this time using the default English locale: https://github.com/EFForg/privacybadger/issues/2043

Comment 8 by phistuck@gmail.com, May 31 2018

In case anyone was wondering, this is the observed behavior -
https://images.masto.donte.com.br/media_attachments/files/000/432/304/original/88392d23d3b6f10c.mp4
Cc: bokan@chromium.org szager@chromium.org
Summary: extension popup auto-scrollbar feedback loop (was: Broken browser popup rendering (caused by scrollbar?))
Might be an interaction between auto scrollbars and auto-resize mode (LocalFrameView::EnableAutoSizeMode).
minimization.zip
1.0 KB Download
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a5701869ce7cd4667ab0b0a29f185be311a5ba

commit b9a5701869ce7cd4667ab0b0a29f185be311a5ba
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Aug 24 23:49:13 2018

Fix feedback loop in extension popup autosizing.

FrameViewAutoSizeInfo should not add hypothetical vertical scrollbar
space when we already have a real vertical scrollbar.

The real scrollbar is included in the LayoutView's preferred width
(since crrev.com/397112).  If the redundant accomodation makes the
scrollbar detectably unnecessary, the next autosize reduces the width,
making it appear again.

The autosized FrameView now accomodates exactly one vertical scrollbar
in this scenario, instead of infinitely bouncing between two and zero.
The scrollbar could actually be removed even at this size, but the code
isn't smart enough to detect that.

Bug:  838150 
Change-Id: I23dce5a37faed33de978e1d2182009a2fe0c6fd1
Reviewed-on: https://chromium-review.googlesource.com/1188767
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586062}
[modify] https://crrev.com/b9a5701869ce7cd4667ab0b0a29f185be311a5ba/third_party/blink/renderer/core/frame/frame_view_auto_size_info.cc
[modify] https://crrev.com/b9a5701869ce7cd4667ab0b0a29f185be311a5ba/third_party/blink/renderer/core/layout/scrollbars_test.cc

Status: Fixed (was: Started)
Should be fixed in dev channel (70.0.3534.4).

Sign in to add a comment