New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838147 link

Starred by 1 user
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Apr 2018
Cc:
beaufort...@gmail.com
█ apaci...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: crash when player reset while in PIP

Project Member Reported by mlamouri@chromium.org, Apr 30 2018 
STR:
1. open https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
2. send in PIP
3. in devtools, sets the video src to '' (`video.src = ''`)

Expected result: player is reset, no longer in pip.
Actual result: crash because when resetting the player, it tries to show the layer on the page.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9111d612894b17c907f4328121ff2bec9c776b73

commit 9111d612894b17c907f4328121ff2bec9c776b73
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Apr 30 17:20:17 2018

Picture-in-Picture: check if we have a layer when hiding the interstitial.

When the player is destroyed, it notifies the element which then hides
the interstitial. In a regular scenario, when the interstitial is hidden,
the layer on the page should be visible again. However, when the player
is destroyed, there is no more layer.

Bug:  838147 
Change-Id: I1d3a8970246d8f867fecd7ed7a5a1d9f371f7e5c
Reviewed-on: https://chromium-review.googlesource.com/1035262
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554798}
[add] https://crrev.com/9111d612894b17c907f4328121ff2bec9c776b73/third_party/WebKit/LayoutTests/media/picture-in-picture/clear-player-during-pip.html
[modify] https://crrev.com/9111d612894b17c907f4328121ff2bec9c776b73/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc

Comment 2 by mlamouri@chromium.org, Apr 30 2018

Status: Fixed (was: Started)
►

Sign in to add a comment