cros_config: Support to Query Property by Assigning A SKU ID |
|||||
Issue descriptionCurrently cros_config in the DUT supports two use cases: 1. All information including platform name, sku id, config and VPD are all collected from the DUT. Then the queried properties are locked into this combination (a certain model). 2. All info above are all provided by arguments explicitly. Would like to propose third use cases: 3. Only sku id is given by explicit argument but others are all collected from DUT. This will be used in the factory in order to verify whether new sku id from shopfloor belongs to the same oem id in the EEPROM. In this scenario, before really writing new sku id into EEPROM we should verify it's oem id first. Therefore we need third use case supported by cros_config for querying the property of model mapped from new sku id. If we leverage use case 2, then we need to probe platform name and VPD in the factory test but which should be covered by cros_confg already.
,
May 2 2018
re#1, Yes, that is exactly what I need and thanks.
,
May 10 2018
Hi Charles, If you are starting to work on this then may I take it? Thanks.
,
May 15 2018
chat with Charles offline and I would take this one first.
,
May 15 2018
,
May 17 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b77efdc02429fdb4395bca065ed5e51000be0d90 commit b77efdc02429fdb4395bca065ed5e51000be0d90 Author: Marco Chen <marcochen@chromium.org> Date: Thu May 31 19:26:08 2018 chromeos-config: support to query property by assigning the SKU ID. Currrently cros_config only allows you to query the property in the SKU ID of this device if test database is not passed in. But in some use cases, we would need to do query for a SKU ID other then this device belonged to and use the default database in this device. BUG= chromium:838134 TEST=build new image and manually test in the DUT Change-Id: Ia57562b3d4082285838b8f67b847d67cc615918e Reviewed-on: https://chromium-review.googlesource.com/1065721 Commit-Ready: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> Reviewed-by: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/b77efdc02429fdb4395bca065ed5e51000be0d90/chromeos-config/libcros_config/identity_x86.h [modify] https://crrev.com/b77efdc02429fdb4395bca065ed5e51000be0d90/chromeos-config/cros_config_main.cc [modify] https://crrev.com/b77efdc02429fdb4395bca065ed5e51000be0d90/chromeos-config/libcros_config/cros_config.cc [modify] https://crrev.com/b77efdc02429fdb4395bca065ed5e51000be0d90/chromeos-config/libcros_config/cros_config.h
,
Jun 1 2018
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a932680259b6c5d9b902c9c1e5c3f2703bc6a55a commit a932680259b6c5d9b902c9c1e5c3f2703bc6a55a Author: Marco Chen <marcochen@chromium.org> Date: Thu Jul 19 02:28:22 2018 chromeos-config: support to query property by assigning the SKU ID. Currrently cros_config only allows you to query the property in the SKU ID of this device if test database is not passed in. But in some use cases, we would need to do query for a SKU ID other then this device belonged to and use the default database in this device. BUG= chromium:838134 TEST=build new image and manually test in the DUT Change-Id: Ia57562b3d4082285838b8f67b847d67cc615918e Reviewed-on: https://chromium-review.googlesource.com/1065721 Commit-Ready: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> Reviewed-by: Marco Chen <marcochen@chromium.org> (cherry picked from commit b77efdc02429fdb4395bca065ed5e51000be0d90) Reviewed-on: https://chromium-review.googlesource.com/1141999 Commit-Queue: Marco Chen <marcochen@chromium.org> [modify] https://crrev.com/a932680259b6c5d9b902c9c1e5c3f2703bc6a55a/chromeos-config/libcros_config/identity_x86.h [modify] https://crrev.com/a932680259b6c5d9b902c9c1e5c3f2703bc6a55a/chromeos-config/cros_config_main.cc [modify] https://crrev.com/a932680259b6c5d9b902c9c1e5c3f2703bc6a55a/chromeos-config/libcros_config/cros_config.cc [modify] https://crrev.com/a932680259b6c5d9b902c9c1e5c3f2703bc6a55a/chromeos-config/libcros_config/cros_config.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shapiroc@chromium.org
, May 1 2018Status: Assigned (was: Untriaged)