New issue
Advanced search Search tips

Issue 838133 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 563816



Sign in to add a comment

Implement blocking commit on OffscreenCanvas

Project Member Reported by fs...@chromium.org, Apr 30 2018

Issue description

Due to the new OffscreenCanvas submit model:
https://github.com/junov/OffscreenCanvasAnimation/blob/master/OffscreenCanvasAnimation.md

This is the tracking bug.
 

Comment 1 by fs...@chromium.org, Apr 30 2018

Labels: -Pri-3 Pri-2

Comment 2 by fs...@chromium.org, May 14 2018

Blocking: 563816
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001

commit cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001
Author: Fernando Serboncini <fserb@chromium.org>
Date: Thu May 24 17:53:36 2018

Implements blocking commit on OffscreenCanvas

Implemented with a Mojo sync API.

Note that an alternate approach with WaitableEvent was attemped
for this, but the fact that we need to wait on two IPCs, added
a lot of complexity for thread hops for Mojo, and ends up
being much more complicated.

Bug:  838133 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id512c86b0df0ecba3ee9965801be916165d4c0cf
Reviewed-on: https://chromium-review.googlesource.com/1043008
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561545}
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/services/ui/ws/compositor_frame_sink_client_binding.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/services/ui/ws/compositor_frame_sink_client_binding.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.https-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.commit-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.commit.w-expected.txt
[delete] https://crrev.com/a9f6fb3f8c034d896418f836ef6a13fa217399e7/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.resize-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-copyImage.html
[delete] https://crrev.com/a9f6fb3f8c034d896418f836ef6a13fa217399e7/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-opaque-background-compositing-expected.html
[delete] https://crrev.com/a9f6fb3f8c034d896418f836ef6a13fa217399e7/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-opaque-background-compositing.html
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-imageBitmap-from-offscreen-canvas-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-imageBitmap-from-offscreen-canvas.html
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[add] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/virtual/display-compositor-pixel-dump/fast/canvas/display-compositor-pixel-dump/OffscreenCanvas-opaque-background-compositing-expected.html
[add] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/virtual/display-compositor-pixel-dump/fast/canvas/display-compositor-pixel-dump/OffscreenCanvas-opaque-background-compositing.html
[add] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/virtual/display-compositor-pixel-dump/fast/canvas/display-compositor-pixel-dump/README.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.idl
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h
[modify] https://crrev.com/cf60c7cbbb47366f5c13e2ddcbdb3c0f98122001/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

Comment 4 by fs...@chromium.org, May 24 2018

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6

commit a5f88b7e35a567c40e25e21b285ec7e8c687e6d6
Author: James Darpinian <jdarpinian@chromium.org>
Date: Mon Nov 12 23:09:19 2018

Cleaning up WebGL test failure expectations.

Many of these are leftover failure expectations from fixed bugs.
Some were fixed on some platforms but not others. There are some
new failures that were hidden by previous broad suppressions. Also
some tests are only failing because we haven't updated the drivers
on the bots (http://crbug.com/887241).

Bug:  757097 ,  838133 ,  672380 , 625738,  angleproject:2325 
Bug:  534697 , 849572, 625738, 703779,  angleproject:2142 
Bug: 757098, 644740, 705865, 602688,  angleproject:2103 
Bug: 903903,  740769 , 662644,  680720 ,  angleproject:1932 
Bug:  709874 , 887241,  625365 , angleproject:2952
Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00
Reviewed-on: https://chromium-review.googlesource.com/c/1325197
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607367}
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py

Sign in to add a comment