New issue
Advanced search Search tips

Issue 838128 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 795370



Sign in to add a comment

Run LayoutTests with videos using SurfaceLayer

Project Member Reported by mlamouri@chromium.org, Apr 30 2018

Issue description

This will be done in two steps:
- run a virtual test suite
- run all layout tests
 
Blockedon: 795370
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0339327916572e6a379a4b91eeb1952c1ee3133

commit c0339327916572e6a379a4b91eeb1952c1ee3133
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed May 02 23:39:54 2018

Create LayoutTests virtual target for VideoSurfaceLayer.

This adds a virtual/video-surface-layer/ that runs with the feature
enabled and uses a flag to properly do pixel comparison using browser
compositor in addition of the renderer compositor.

Bug: 838128
Change-Id: I2bd7306b156b1e49e1404f5f3b3803b8e6771d4b
Reviewed-on: https://chromium-review.googlesource.com/1034289
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555610}
[modify] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.txt
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-no-audio-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-no-audio-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/video-surface-layer/media/video-no-audio-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.txt
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-layer-crash-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.txt
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-layer-crash-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/platform/win7/virtual/video-surface-layer/media/video-zoom-controls-actual.txt
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/virtual/video-surface-layer/media/README.txt
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/virtual/video-surface-layer/media/video-transformed-expected.png
[add] https://crrev.com/c0339327916572e6a379a4b91eeb1952c1ee3133/third_party/WebKit/LayoutTests/virtual/video-surface-layer/media/video-transformed-expected.txt

Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7971e79592788e8cd99bb387c2674518f0a69562

commit 7971e79592788e8cd99bb387c2674518f0a69562
Author: Marc Treib <treib@chromium.org>
Date: Thu May 03 15:48:12 2018

Add [ Failure ] for video-surface-layer version of networkState_during_progress.html

The version without the "virtual/video-surface-layer/" prefix already had it.

Bug: 520736,838128
Change-Id: I815f420dd134143837d1602e795075176f4e4eb5
Reviewed-on: https://chromium-review.googlesource.com/1042565
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555746}
[modify] https://crrev.com/7971e79592788e8cd99bb387c2674518f0a69562/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7138ee15fb0f2f07df5698d870f25dc669634753

commit 7138ee15fb0f2f07df5698d870f25dc669634753
Author: Marc Treib <treib@chromium.org>
Date: Fri May 04 08:55:18 2018

Skip video-surface-layer version of document-user-activation.html on Linux

It fails with the leak detector. The version without the
"virtual/video-surface-layer/" prefix was already being skipped.

TBR=mlamouri@chromium.org

Bug: 838128
Change-Id: Icb4e898e9c24c20b94cd5bfb51042b65e1ace7d4
Reviewed-on: https://chromium-review.googlesource.com/1043865
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556015}
[modify] https://crrev.com/7138ee15fb0f2f07df5698d870f25dc669634753/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment