macviews: remove secondary-ui-md flag |
|||||||||
Issue descriptionIt doesn't do anything in polychrome builds except break some of the browser UI.
,
Jun 20 2018
,
Jul 12
,
Jul 12
,
Jul 26
,
Aug 2
MacViews triage: punting cleanup work to M70.
,
Aug 17
,
Aug 17
secondary-ui-md was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1162901 but we should kill #show-all-dialogs-with-views-toolkit too
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ae5f4bf5ed54f600b82e13be6f32c24872096c0 commit 7ae5f4bf5ed54f600b82e13be6f32c24872096c0 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Aug 22 16:49:05 2018 Mac: Remove Cocoa GlobalErrorBubble Bug: 838119 Change-Id: Id2821c2e0fe8cdabc2cfa8d239656835be34c0ba Reviewed-on: https://chromium-review.googlesource.com/1181872 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#585084} [modify] https://crrev.com/7ae5f4bf5ed54f600b82e13be6f32c24872096c0/chrome/app/nibs/BUILD.gn [delete] https://crrev.com/0d3824d5abfb6ea8a57928b7ec11152a499307a2/chrome/app/nibs/GlobalErrorBubble.xib [modify] https://crrev.com/7ae5f4bf5ed54f600b82e13be6f32c24872096c0/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/0d3824d5abfb6ea8a57928b7ec11152a499307a2/chrome/browser/ui/cocoa/global_error_bubble_controller.h [delete] https://crrev.com/0d3824d5abfb6ea8a57928b7ec11152a499307a2/chrome/browser/ui/cocoa/global_error_bubble_controller.mm [delete] https://crrev.com/0d3824d5abfb6ea8a57928b7ec11152a499307a2/chrome/browser/ui/cocoa/global_error_bubble_controller_views.mm [modify] https://crrev.com/7ae5f4bf5ed54f600b82e13be6f32c24872096c0/chrome/browser/ui/views/global_error_bubble_view.cc
,
Aug 24
Able to reproduce the issue on chrome version 68.0.3421.0 (build without fix) as per the comment #0 Verified the fix on Mac 10.13.6 using Chrome version #70.0.3532.0. Attaching screen-cast for reference. Observed that " removed secondary-UI-md flag " The fix is working as expected, adding Verified labels Thanks...!
,
Aug 24
Opened Issue 877493 for #show-all-dialogs-with-views-toolkit, closing this one |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ellyjo...@chromium.org
, Apr 30 2018