New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838103 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'CONFIRM' button is seen enabled without entering any characters in 'Confirm your password' dialog box of of chrome://settings/lockScreen page

Project Member Reported by mmanchala@chromium.org, Apr 30 2018

Issue description

Chrome Version:  68.0.3405.0/10631.0.0 dev-channel Peppy,Kip & Paine
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option
2)In 'Confirm your password' dialog box observe  'CONFIRM' button is seen enabled without entering any characters
(Please refer Video and screenshot)


Expected:  'CONFIRM' button should be enabled after entering required characters limit
Actual: Instead 'CONFIRM' button is seen enabled without entering any characters

This is Regression Issue as same is working fine in M-66

Note : Issue is also seen on M-67

@sammiequon : Please confirm the Issue
 
Actual_EnabledSubmitButton.webm
611 KB View Download
Actual_EnabledSubmitButton.jpg
177 KB View Download
Expected_DisabledSubmitButton.jpg
774 KB View Download
Expected_DisabledSubmitButton.mp4
4.5 MB View Download
Labels: ReleaseBlock-Stable
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c774bb2fc112351708f428996af0659120982f63

commit c774bb2fc112351708f428996af0659120982f63
Author: Sammie Quon <sammiequon@google.com>
Date: Wed May 16 21:26:57 2018

settings: Disable lock screen password prompt button when no password.

Test: covered by tests
Bug:  838103 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0bde97d3398ae60968d3646ee8254d24270c84df
Reviewed-on: https://chromium-review.googlesource.com/1056227
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559299}
[modify] https://crrev.com/c774bb2fc112351708f428996af0659120982f63/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/c774bb2fc112351708f428996af0659120982f63/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/c774bb2fc112351708f428996af0659120982f63/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Status: Fixed (was: Assigned)

Sign in to add a comment