CrSettingsCrostiniPageTest.All failing on chromium.chromiumos/linux-chromeos-dbg |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@chromium.org browser_tests failing on chromium.chromiumos/linux-chromeos-dbg Builders failed on: - linux-chromeos-dbg: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg The failing test is CrSettingsCrostiniPageTest.All First seen to fail on https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5408 A clearer example https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5409
,
Apr 30 2018
I can't revert, due to non-trivial merge conflicts. I will disable the test instead.
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de283c36cd486f2414fbdec92debc8f93d8f695f commit de283c36cd486f2414fbdec92debc8f93d8f695f Author: Christos Froussios <cfroussios@chromium.org> Date: Mon Apr 30 11:55:02 2018 Disable CrSettingsCrostiniPageTest.All on ChromeOS dbg The test is failing and the offending CL cannot be trivially reverted. TBR=rjwright@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838097 Change-Id: I1f32a74ab6693f0532c9edc2cbc0af554b2ae656 Reviewed-on: https://chromium-review.googlesource.com/1034684 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554724} [modify] https://crrev.com/de283c36cd486f2414fbdec92debc8f93d8f695f/chrome/test/data/webui/settings/cr_settings_browsertest.js
,
Apr 30 2018
,
Apr 30 2018
The builder is green now.
,
May 1 2018
,
May 1 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87fcd9a90813432bbfc727143b5c6810c48353a5 commit 87fcd9a90813432bbfc727143b5c6810c48353a5 Author: Renee Wright <rjwright@chromium.org> Date: Tue May 08 05:31:53 2018 Remove dialog part of CrostiniPageTests & re-enable This test was failing in debug. onRemoveTap_: function(event) { this.showRemoveDialog_ = true; this.async(() => this.$$('#removeDialog').showModal()); }, in cs.chromium.org/chromium/src/chrome/browser/resources/settings/crostini_page/crostini_subpage.js always comes up with this.$$('#removeDialog').showModal == undefined in debug. I do not know why. But this dialog is being replace with a View dialog very soon anyway. Bug: 838097 Change-Id: Id78b498ee9ce54849793eb9518bbb513a426f13d Reviewed-on: https://chromium-review.googlesource.com/1036710 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556698} [modify] https://crrev.com/87fcd9a90813432bbfc727143b5c6810c48353a5/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/87fcd9a90813432bbfc727143b5c6810c48353a5/chrome/test/data/webui/settings/crostini_page_test.js
,
May 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cfroussios@chromium.org
, Apr 30 2018