New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838083 link

Starred by 1 user
Status: Fixed
Owner:
wzang@chromium.org
Closed: May 2018
Cc:
ajha@chromium.org
r...@chromium.org
█ brajkumar@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression: Back button is seen disabled in 'Network not available' screen

Project Member Reported by rkalavakuntla@chromium.org, Apr 30 2018 
Chrome Version:68.0.3405.0/10631.0.0 dev channel Peppy,Kip,Paine
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >>Sign out 
(2)From Ubertray/Accessibility >>Disable the WiFi 
(3)Click on Add Person to get 'Network not available'screen and Observe the Back button

Actual: Back button is seen disabled in'Network not available'screen
Expected: Back button should be seen enabled in 'Network not available'screen

This is a Regression issue as same is working fine in 67.0.3396.19/10575.17.0 dev

Note:Issue is not seen in Windows,Linux OS

Attached the screencast for reference..

@wzang : Please confirm the issue.
Actual.jpg
1.7 MB View Download
Expected.jpg
2.7 MB View Download
Actual.mp4
6.3 MB View Download
Expected.mp4
7.7 MB View Download

Comment 1 by wzang@chromium.org, Apr 30 2018

Cc: r...@chromium.org jdufault@chromium.org
This is a views-based login regression.
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b1e8cec8394292f39d98737654f32db6bf72995

commit 3b1e8cec8394292f39d98737654f32db6bf72995
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri May 04 01:21:13 2018

cros: Send views-based login user count to display_manager.js

1. Unify the Gaia and network screens to use the same |userCount|.

2. Does not unify the views and WebUI login because:
   1) It's probably better to check $('pod-row').pods.length in WebUI
      since loading the pods takes some time.
   2) The WebUI is being deprecated soon.

Bug:  838083 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifac5797f244d08815e2357404e95c4ba7f9f953a
Reviewed-on: https://chromium-review.googlesource.com/1040769
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555949}
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/resources/chromeos/login/screen_error_message.js
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/3b1e8cec8394292f39d98737654f32db6bf72995/ui/login/display_manager.js

Comment 3 by wzang@chromium.org, May 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment