Issue metadata
Sign in to add a comment
|
Regression : Location bubble is seen slightly shifted downwards in full-screen mode.
Reported by
avsha...@etouch.net,
Apr 30 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 68.0.3415.0 (Official Build) afa8bfeb1ad8a79157f12a1add56654e93d897c5-refs/heads/master@{#554687} 32/64-bit OS : Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to www.google.com 2. Hit F11 to go into full-screen mode and search google for a query "Cars24" 3. Observe the location permission bubble. Actual Result : Location bubble is seen slightly shifted downwards in full-screen mode. Expected Result : No gap should be seen between bubble and top margin of the screen in full-screen mode. This is a regression issue, broken in M-68 and providing the bisect using per-revision script: Good Build : 68.0.3409.0 (Revision : 553715) Bad Build : 68.0.3410.0 (Revision : 554249) You are probably looking for a change made after 553897 (known good), but no later than 553898 (first known bad). CHANGE LOG URL : https://chromium.googlesource.com/chromium/src/+log/689599319903ef86aff7d38b0d1070e547e2e230..780a71ed089233d25709d37f382191e905c55b6f Suspect : https://chromium.googlesource.com/chromium/src/+/780a71ed089233d25709d37f382191e905c55b6f @Alan : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.5) OS.
,
May 1 2018
Looks like this is due to using browser_view->GetLocationBarView()->visible() instead of browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR).
,
May 1 2018
Screenshots of WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1036964
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4393d7d26958ddfde299daed891045bb36ac5045 commit 4393d7d26958ddfde299daed891045bb36ac5045 Author: Alan Cutter <alancutter@chromium.org> Date: Wed May 02 07:33:37 2018 Fix anchoring of permission dialog in full screen mode This CL updates GetPageInfoAnchorView() to check visibility of the view hierarchy instead of just single view elements. In Linux/Windows fullscreen the ToolbarView is not visible while its children's visibility are still set to true so it's not enough to only check their visibility. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=337120&signed_aid=2W8EBRpI7WsrXmCDI0TVEA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=337121&signed_aid=aiaQuXt1dB53LM_ahvCL7Q==&inline=1 Bug: 838079 Change-Id: I223f5f78f61e80f7873347ff77ed21949b405949 Reviewed-on: https://chromium-review.googlesource.com/1036964 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555325} [modify] https://crrev.com/4393d7d26958ddfde299daed891045bb36ac5045/chrome/browser/ui/views/bubble_anchor_util_views.cc
,
May 2 2018
,
May 3 2018
Update : Retested above issue in latest Canary build #68.0.3418.0 on Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Location bubble is seen at it's original position in full-screen mode. Kindly review an attached screen-cast. Thank you..!
,
May 4 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alancutter@chromium.org
, May 1 2018