cros_config: The VPD Name Should be whitelabel_tag not customization_id |
||||
Issue descriptionRefer to [1], cros_config read vpd - customization_id to match both of identify - whitelabel-tag and customization_id. But for whitelabel devices since Coral, only whitelabel-tag is used so SelectConfigByIdentity() would fail. [1] https://chromium.googlesource.com/chromiumos/platform2/+/master/chromeos-config/libcros_config/cros_config.cc#25
,
May 10 2018
,
May 10 2018
will add support for this
,
May 10 2018
,
May 11 2018
Another issue related to whitelabel_tag is noted at https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1054186#message-a1ad5f1ddd02f0f41c5b0a0c5ce30bd7fd73c4b8
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8e30bae74a6a1e2520b032c7059a5e4f93a44ae9 commit 8e30bae74a6a1e2520b032c7059a5e4f93a44ae9 Author: C Shapiro <shapiroc@chromium.org> Date: Fri May 11 02:41:02 2018 chromeos-connfig: Add whitelabel_tag support VPD identity values can be either customization_id or whitelabel_tag. Changed the identity impl in cros_config to support either. mosys already had this support, which is why fw updater worked. This will make cros_config work the same way (where either vpd value is supported). BUG= chromium:838066 TEST=build and test on whitetip Change-Id: I2ea654dff4b58253a19f4bce601832853c44ba56 Reviewed-on: https://chromium-review.googlesource.com/1054186 Commit-Ready: C Shapiro <shapiroc@google.com> Tested-by: C Shapiro <shapiroc@google.com> Reviewed-by: Gregory Meinke <gmeinke@chromium.org> [modify] https://crrev.com/8e30bae74a6a1e2520b032c7059a5e4f93a44ae9/chromeos-config/libcros_config/cros_config_fdt.cc [modify] https://crrev.com/8e30bae74a6a1e2520b032c7059a5e4f93a44ae9/chromeos-config/libcros_config/identity.cc [modify] https://crrev.com/8e30bae74a6a1e2520b032c7059a5e4f93a44ae9/chromeos-config/libcros_config/identity.h [modify] https://crrev.com/8e30bae74a6a1e2520b032c7059a5e4f93a44ae9/chromeos-config/libcros_config/cros_config.cc [modify] https://crrev.com/8e30bae74a6a1e2520b032c7059a5e4f93a44ae9/chromeos-config/libcros_config/cros_config_json.cc
,
May 11 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by marcochen@chromium.org
, Apr 30 2018