Issue metadata
Sign in to add a comment
|
Regression : Text 'सुरक्षित' in 'View site info' icon appears chopped from bottom.
Reported by
rp...@etouch.net,
Apr 30 2018
|
||||||||||||||||||||||
Issue descriptionVersion: 68.0.3415.0 (Official Build) Revision afa8bfeb1ad8a79157f12a1add56654e93d897c5-refs/heads/master@{#554687}(32/64-bit) OS: Windows 7 What steps will reproduce the problem? 1. Launch chrome,and change browser language to 'Hindi' 2. Now navigate to www.google.com and observe text 'सुरक्षित' in 'View site information' icon Actual: Text 'सुरक्षित' in 'View site information' icon appears chopped from bottom Expected: Text 'सुरक्षित' in 'View site information' icon should be seen properly This is regression issue, broken in ‘M 67’ and below is the bisect info : Good build: 67.0.3379.0 (Revision: 545320). Bad build: 67.0.3381.0(Revision: 545918). You are probably looking for a change made after 545331 (known good), but no later than 545332(first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/dbc05d7288913b7584710bac5e299e8defe16a5c..44076c740a2e13b4bf76b9fb21adf7dd2d2c1d08 Suspect : https://chromium.googlesource.com/chromium/src/+/44076c740a2e13b4bf76b9fb21adf7dd2d2c1d08 From the CL above, assigning the issue to the concern owner @tapted- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is also reproducible on M-67 (build # 67.0.3396.18) Beta M-68 Dev (build # 68.0.3409.2). 2. Above issue is not seen on Windows (8,8.1,10),Mac OS X(10.12.6,10.13.1,10.13.5) and Linux (14.04 LTS) Thanks!
,
May 3 2018
Just to update : Rechecked the above issue on Windows 7 machine using latest Canary chrome version : 68.0.3418.0 and the issue is still reproducible with the steps mentioned in the bug. Thank you.
,
May 3 2018
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09115274d6833e9a49a905cc81df26ec5b815e35 commit 09115274d6833e9a49a905cc81df26ec5b815e35 Author: Trent Apted <tapted@chromium.org> Date: Fri May 04 06:49:03 2018 Hardcode Omnibox font size at 14 (ignore user and locale settings). r545332 preserved the omnibox font size of 14 for default user OS configurations but inadvertently started applying scaling logic used for dialog text that the omnibox text field never used. It is 14pt. Always. Revert to the old behaviour. Importantly, the way the size delta was being captured would fail to shrink a font that was too large to fit, if that delta came from user settings rather than font metrics alone. Bug: 831340 , 838065 Change-Id: I1d4a296fa717694bfe77c14d2590d10d0d9c6e9f Reviewed-on: https://chromium-review.googlesource.com/1041390 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#556004} [modify] https://crrev.com/09115274d6833e9a49a905cc81df26ec5b815e35/chrome/browser/ui/views/harmony/chrome_typography.cc [modify] https://crrev.com/09115274d6833e9a49a905cc81df26ec5b815e35/chrome/browser/ui/views/harmony/chrome_typography.h [modify] https://crrev.com/09115274d6833e9a49a905cc81df26ec5b815e35/chrome/browser/ui/views/harmony/layout_provider_unittest.cc
,
May 7 2018
Confirmed the old font size is restored in 68.0.3422.0. Note there is a separate/unrelated regression making fonts look weird for other reasons -- Issue 840010 -- but the size is correct. Requesting merge of r556004 to m67.
,
May 7 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 7 2018
*** Bulk Edit *** M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
,
May 7 2018
,
May 7 2018
Confirmed fixed also in 68.0.3423.2 which has the fix for Issue 840010 . re #c6 and "Reverts referenced in bugdroid comments", there isn't actually any revert here. The comment just says we're fixing this issue by reverting to the m66 behavior. Note there is additional impact of the regression. Devenagari/Hindi scripts are affected because locale settings increase the default font size, but the default font size can be increased in other ways via user settings. Currently, if user settings specific a much larger font size they can also be affected by this text clipping.
,
May 7 2018
Approving merge to M67 branch 3396 based on comments #5 and #9. Pls merge ASAP. Thank you.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab972de732ecb207beccdc99809eec1b200d48da commit ab972de732ecb207beccdc99809eec1b200d48da Author: Trent Apted <tapted@chromium.org> Date: Tue May 08 00:42:05 2018 [merge-m67] Hardcode Omnibox font size at 14 (ignore user and locale settings). r545332 preserved the omnibox font size of 14 for default user OS configurations but inadvertently started applying scaling logic used for dialog text that the omnibox text field never used. It is 14pt. Always. Revert to the old behaviour. Importantly, the way the size delta was being captured would fail to shrink a font that was too large to fit, if that delta came from user settings rather than font metrics alone. TBR=tapted@chromium.org (cherry picked from commit 09115274d6833e9a49a905cc81df26ec5b815e35) Bug: 831340 , 838065 Change-Id: I1d4a296fa717694bfe77c14d2590d10d0d9c6e9f Reviewed-on: https://chromium-review.googlesource.com/1041390 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556004} Reviewed-on: https://chromium-review.googlesource.com/1049085 Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#511} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/ab972de732ecb207beccdc99809eec1b200d48da/chrome/browser/ui/views/harmony/chrome_typography.cc [modify] https://crrev.com/ab972de732ecb207beccdc99809eec1b200d48da/chrome/browser/ui/views/harmony/chrome_typography.h [modify] https://crrev.com/ab972de732ecb207beccdc99809eec1b200d48da/chrome/browser/ui/views/harmony/layout_provider_unittest.cc
,
May 8 2018
,
May 8 2018
Rechecked the above issue on Windows 7 OS using latest Canary build #68.0.3424.0 and the issue is fixed. Please refer the attached screen cast for reference.
,
May 8 2018
The NextAction date has arrived: 2018-05-08 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mencinares@google.com
, Apr 30 2018Labels: Needs-TestConfirmation