Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@chromium.org mash_ash_unittests failing on multiple builders Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ab3884b24d56b8ade0473b992e249bed7ef0fcc commit 1ab3884b24d56b8ade0473b992e249bed7ef0fcc Author: Christos Froussios <cfroussios@chromium.org> Date: Mon Apr 30 08:50:24 2018 Revert "overview: Initial patch for overview swipe to close." This reverts commit 209edd5625d2f6d10422e0ed3d19f71a8b3b4e91. Reason for revert: The test SplitViewWindowSelectorTest.DragToClose is flaky (mostly failing) on builder Linux Chromium OS ASan LSan Tests e.g. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27234 Original change's description: > overview: Initial patch for overview swipe to close. > > Adds ability to drag the overview item up or fling the item up to close > the window. A later cl will add the fling animation. The feature is > hidden behind a newly added flag. > > Test: added test coverage > Bug: 828646 > Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee > Reviewed-on: https://chromium-review.googlesource.com/1014490 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554651} TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828646, 838061 Change-Id: I3eaedf6f764120131b4da729c7425056ef2bd018 Reviewed-on: https://chromium-review.googlesource.com/1033673 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554710} [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/public/cpp/ash_features.cc [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/public/cpp/ash_features.h [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/overview_utils.h [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/overview_window_drag_controller.cc [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/overview_window_drag_controller.h [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/window_selector.cc [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/window_selector.h [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/1ab3884b24d56b8ade0473b992e249bed7ef0fcc/ash/wm/overview/window_selector_unittest.cc
Failure is fixed. Assigning to the owner of the reverted CL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/912416a20f8aea75e388da3b25c2810b60b266a5 commit 912416a20f8aea75e388da3b25c2810b60b266a5 Author: Sammie Quon <sammiequon@google.com> Date: Tue May 01 00:27:40 2018 Reland "overview: Initial patch for overview swipe to close." This is a reland of 209edd5625d2f6d10422e0ed3d19f71a8b3b4e91 Original change's description: > overview: Initial patch for overview swipe to close. > > Adds ability to drag the overview item up or fling the item up to close > the window. A later cl will add the fling animation. The feature is > hidden behind a newly added flag. > > Test: added test coverage > Bug: 828646 > Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee > Reviewed-on: https://chromium-review.googlesource.com/1014490 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554651} Bug: 828646, 838061 Change-Id: Ifa3c4f33c6831c5f5e06c62682893680a5e4c27b Reviewed-on: https://chromium-review.googlesource.com/1035368 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554938} [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/public/cpp/ash_features.cc [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/public/cpp/ash_features.h [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/overview_utils.h [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/overview_window_drag_controller.cc [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/overview_window_drag_controller.h [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/window_selector.cc [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/window_selector.h [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/912416a20f8aea75e388da3b25c2810b60b266a5/testing/buildbot/filters/mash.ash_unittests.filter
Comment 1 by bugdroid1@chromium.org
, Apr 30 2018