CL https://chromium-review.googlesource.com/c/chromium/src/+/1030670 broke WebKit Linux Trusty ASAN

Example failure
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/11386

The culprit also broke WebKit Linux Trusty MSAN
E.g. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7428

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4189fd6b16899bef539939ab6d3028d17415232

commit c4189fd6b16899bef539939ab6d3028d17415232
Author: Christos Froussios <cfroussios@chromium.org>
Date: Mon Apr 30 09:12:04 2018

Revert "OOR-CORS: store more information to CORSErrorStatus on preflight errors"

This reverts commit 1f675b46670aff95516ec8b9d61bc0f55e930a47.

Reason for revert: Breaks builder WebKit Linux Trusty ASAN

Original change's description:
> OOR-CORS: store more information to CORSErrorStatus on preflight errors
> 
> Current implementation does not store rejected method or header
> information to CORSErrorStatus on CORS-preflight checks, and
> results in missing hint parameter on CreateErrorString() in Blink.
> This patch provides required information to generate right error
> messages, and fixes some crashed layout tests.
> 
> Bug:  803766 ,  836741 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: If4de6b916a77d204812a7b010e39080bf059bc9e
> Tbr: kinuko@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/1030670
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554642}

TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  803766 ,  836741 ,  838057 
Change-Id: Ia8eb9bf63b1b0c6edda93eb7d45c1bb20d26a7b7
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1034532
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554712}
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/services/network/public/cpp/cors/cors_error_status.cc
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/services/network/public/cpp/cors/cors_error_status.h
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/third_party/blink/renderer/core/loader/document_threadable_loader.cc
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/third_party/blink/renderer/platform/loader/cors/cors_error_string.h
[modify] https://crrev.com/c4189fd6b16899bef539939ab6d3028d17415232/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Test failure fixed. Assigning to the author.

Reverting fixed the ASAN and MSAN failures, but created new failures :(

WebKit Linux Trusty Leak
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/18307
WebKit Win10
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/34226
WebKit Mac10.11 (dbg)
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/15227

Possibly even more coming.
I will undo the revert and disable the test on ASAN and MSAN instead.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4741ed4fb65821a94134605ad9ecaf11b61b6786

commit 4741ed4fb65821a94134605ad9ecaf11b61b6786
Author: Christos Froussios <cfroussios@chromium.org>
Date: Mon Apr 30 12:25:55 2018

Reland "OOR-CORS: store more information to CORSErrorStatus on preflight errors"

This reverts commit c4189fd6b16899bef539939ab6d3028d17415232.

Reason for revert: Reverting caused other, bigger failures. I will
disable the test instead.

Original change's description:
> Revert "OOR-CORS: store more information to CORSErrorStatus on preflight errors"
> 
> This reverts commit 1f675b46670aff95516ec8b9d61bc0f55e930a47.
> 
> Reason for revert: Breaks builder WebKit Linux Trusty ASAN
> 
> Original change's description:
> > OOR-CORS: store more information to CORSErrorStatus on preflight errors
> > 
> > Current implementation does not store rejected method or header
> > information to CORSErrorStatus on CORS-preflight checks, and
> > results in missing hint parameter on CreateErrorString() in Blink.
> > This patch provides required information to generate right error
> > messages, and fixes some crashed layout tests.
> > 
> > Bug:  803766 ,  836741 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> > Change-Id: If4de6b916a77d204812a7b010e39080bf059bc9e
> > Tbr: kinuko@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/1030670
> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#554642}
> 
> TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  803766 ,  836741 ,  838057 
> Change-Id: Ia8eb9bf63b1b0c6edda93eb7d45c1bb20d26a7b7
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1034532
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554712}

TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org,cfroussios@chromium.org

Change-Id: Iaf20d807cf9f71976a3d1c8a46678afb48682029
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  803766 ,  836741 ,  838057 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1034702
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554726}
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/services/network/public/cpp/cors/cors_error_status.cc
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/services/network/public/cpp/cors/cors_error_status.h
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/third_party/blink/renderer/core/loader/document_threadable_loader.cc
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/third_party/blink/renderer/platform/loader/cors/cors_error_string.h
[modify] https://crrev.com/4741ed4fb65821a94134605ad9ecaf11b61b6786/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a512d546273e460f886ca94e87d6a39e2502a33e

commit a512d546273e460f886ca94e87d6a39e2502a33e
Author: Christos Froussios <cfroussios@chromium.org>
Date: Mon Apr 30 12:59:35 2018

Disable some CORS tests on MSAN and ASAN

The following test crash consistently
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.worker.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight-star.any.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight-star.any.worker.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight.any.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-preflight.any.worker.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-redirect-preflight.any.html
virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-redirect-preflight.any.worker.html
virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html
virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html

No-try: true
No-Presubmit: true
Bug:  838057 
Change-Id: I327e21e628b34b710f4df2f2b171bbf80363893a
Reviewed-on: https://chromium-review.googlesource.com/1034689
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554729}
[modify] https://crrev.com/a512d546273e460f886ca94e87d6a39e2502a33e/third_party/WebKit/LayoutTests/ASANExpectations
[modify] https://crrev.com/a512d546273e460f886ca94e87d6a39e2502a33e/third_party/WebKit/LayoutTests/MSANExpectations

Seems fixed

This isn't fixed; the test is just disabled.

Note: I'm changing one "[Crash]" expectation to "[Pass Crash]" since it is flakily passing (see  Issue 873045 ).

virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html [ Pass Crash ]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c441d2c33570fc281cef35a61169ad41a1a76b

commit 67c441d2c33570fc281cef35a61169ad41a1a76b
Author: Matt Giuca <mgiuca@chromium.org>
Date: Fri Aug 10 05:42:52 2018

WebKit Layout Tests: Disable a lot of flaky tests on MSAN.

Adds a bunch of tests with high-probability flake due to timeout or
crash, to existing lists of very similar tests that were already
disabled.

Tbr: mgiuca@chromium.org
Bug:  873045 ,  838057 , 856601, 869818
Change-Id: I66e14994ef4551d5690d3a66d51fce84a1eaf456
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1170450
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582068}
[modify] https://crrev.com/67c441d2c33570fc281cef35a61169ad41a1a76b/third_party/WebKit/LayoutTests/MSANExpectations

Most of crashes are fixed. Others (fetch-canvas-tainting-*) are not specific to outofblink-cors.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fservice-workers%2Fservice-worker%2Ffetch-canvas-tainting-video-cache.https.html
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fservice-workers%2Fservice-worker%2Ffetch-canvas-tainting-video.https.html

I filed issue 873873 for the issue.

Actually they are not crashy. I'll remove the expectations and close this bug.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fc51b557137051dd199c1f1f710f92dff272462

commit 9fc51b557137051dd199c1f1f710f92dff272462
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Aug 14 01:47:40 2018

Update test expectations for virtual/outofblink-cors

Remove many expectations as they are obsolete and add two related flaky
expecations.

Bug: 873873,  838057 
Change-Id: Ife7c566fb7b41c21cb7ad2bfeb30c81da62b56f1
Reviewed-on: https://chromium-review.googlesource.com/1173194
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582791}
[modify] https://crrev.com/9fc51b557137051dd199c1f1f710f92dff272462/third_party/WebKit/LayoutTests/MSANExpectations
[modify] https://crrev.com/9fc51b557137051dd199c1f1f710f92dff272462/third_party/WebKit/LayoutTests/TestExpectations