New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838018 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failure: layout_snapped_paint_offset == snapped_paint_offset || subpixel_accumulation_may

Project Member Reported by ClusterFuzz, Apr 30 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5079062121545728

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  layout_snapped_paint_offset == snapped_paint_offset || subpixel_accumulation_may
  blink::CompositingLayerPropertyUpdater::Update
  blink::PrePaintTreeWalk::WalkInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=543289:543291

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5079062121545728

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 30 2018

Components: Blink>Compositing Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Owner: trchen@chromium.org
Status: Assigned (was: Untriaged)
A clusterfuzz repro of the known DCHECK issue?
 Issue 845585  has been merged into this issue.
Cc: trchen@chromium.org
 Issue 836358  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa2bc60d0b9133f068705dedd09bd5009919e35

commit faa2bc60d0b9133f068705dedd09bd5009919e35
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Sat Jun 02 00:49:36 2018

[Blink/SPv175] Disable subpixel accumulation check in layer property updater

The DCHECK has been triggered by a clusterfuzz. Disable while we investigate it.

BUG= 838018 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3c4231010f7029f532016eb3cf095109779847c1
Reviewed-on: https://chromium-review.googlesource.com/1083675
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563889}
[modify] https://crrev.com/faa2bc60d0b9133f068705dedd09bd5009919e35/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc

Project Member

Comment 6 by ClusterFuzz, Jun 2 2018

ClusterFuzz has detected this issue as fixed in range 563882:563889.

Detailed report: https://clusterfuzz.com/testcase?key=5079062121545728

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  layout_snapped_paint_offset == snapped_paint_offset || subpixel_accumulation_may
  blink::CompositingLayerPropertyUpdater::Update
  blink::PrePaintTreeWalk::WalkInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=543289:543291
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=563882:563889

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5079062121545728

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jun 2 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5079062121545728 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Pri-1 Pri-2
Status: Assigned (was: Verified)
Keep this bug open for tracking.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f

commit 8661a7c51be77ca3e6a154e7fbade0b799eb6d9f
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Wed Sep 12 02:30:35 2018

[Blink/BGPT+SPv2] Implement sticky position as transform node

This CL extracts sticky offset from paint offset and apply it as a
transform node instead.

BUG= 762098 , 838018 , 877196 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6706f09e26ca4549f58500e45153970edfcedc28
Reviewed-on: https://chromium-review.googlesource.com/1208449
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590578}
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-normal-scroller-expected.html
[add] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-normal-scroller.html
[add] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflow-hidden-expected.html
[add] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflow-hidden.html
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/object_paint_properties.h
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/platform/graphics/compositor_element_id.cc
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/platform/graphics/compositor_element_id.h
[modify] https://crrev.com/8661a7c51be77ca3e6a154e7fbade0b799eb6d9f/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h

Status: Fixed (was: Assigned)

Sign in to add a comment