wifi: autotest: clean up pylint warnings |
|
Issue descriptionTracking only. This is almost busy-work, but I'd like to reduce the noise devs deal with when adding a new test or making changes.
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/28605b457595981467e5ec7863cfa0a30186b7c6 commit 28605b457595981467e5ec7863cfa0a30186b7c6 Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue May 01 15:31:49 2018 network_WiFi_MalformedProbeResp: Keep pylint happy This fixes the following warnings: ************* Module network_WiFi_MalformedProbeResp W: 48, 8: Unused variable 'count' (unused-variable) W: 49, 8: Unused variable 'scan' (unused-variable) W: 46, 8: Unused variable 'assoc_result' (unused-variable) BUG=chromium:838014 TEST=None Change-Id: If32e21342c2f9d4225b3f33e09c4c07ba869b9aa Reviewed-on: https://chromium-review.googlesource.com/1034381 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/28605b457595981467e5ec7863cfa0a30186b7c6/server/site_tests/network_WiFi_MalformedProbeResp/network_WiFi_MalformedProbeResp.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/82c241d23e6edf6f75095e12db743cd7899def3a commit 82c241d23e6edf6f75095e12db743cd7899def3a Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue May 01 15:31:41 2018 network_WiFi_RegDomain: Keep pylint happy Use _ for loop index since pylint knows to ignore it. BUG=chromium:838014 TEST=None Change-Id: Icc8b7c91da2a9f18c40b59b3b978e739a81bdbd6 Reviewed-on: https://chromium-review.googlesource.com/1034382 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/82c241d23e6edf6f75095e12db743cd7899def3a/server/site_tests/network_WiFi_RegDomain/network_WiFi_RegDomain.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/df0aa880a36ddd0dfd8dbcab78476e613aedf6a8 commit df0aa880a36ddd0dfd8dbcab78476e613aedf6a8 Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue May 01 20:06:51 2018 wifi_proxy: Remove unused import. This makes pylint happier. BUG=chromium:838014 TEST=None Change-Id: I5e576a5539faec65e77fd5aa97b9d2d75a9abb2f Reviewed-on: https://chromium-review.googlesource.com/1034374 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/df0aa880a36ddd0dfd8dbcab78476e613aedf6a8/client/cros/networking/wifi_proxy.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d3309623414ae20663b5c7bda875165b084dcd43 commit d3309623414ae20663b5c7bda875165b084dcd43 Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue May 01 20:06:41 2018 wifi_proxy: Replace mutable list argument with None This fixes the following pylint warning: W: 44, 4: Dangerous default value {} as argument (dangerous-default-value) From the python docs: (https://docs.python.org/3/tutorial/controlflow.html#default-argument-values) The default value is evaluated only once. This makes a difference when the default is a mutable object such as a list, dictionary, or instances of most classes. A function with a mutable argument accumulates the arguments passed to it on subsequent calls. BUG=chromium:838014 TEST=None Change-Id: I5a4bef88a911ba75b1a0eca0cc6924a45615b59a Reviewed-on: https://chromium-review.googlesource.com/1034376 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/d3309623414ae20663b5c7bda875165b084dcd43/client/cros/networking/wifi_proxy.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9efc0c7c0f6da1c23f870e961bd0525728a4230a commit 9efc0c7c0f6da1c23f870e961bd0525728a4230a Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue May 01 20:06:42 2018 wifi_proxy: Remove unused variable service_proxy This fixes pylint warning: W:133, 8: Unused variable 'service_proxy' (unused-variable) BUG=chromium:838014 TEST=None Change-Id: Iaeb8171f0ff3de7e24b4a752e28468030c5439ec Reviewed-on: https://chromium-review.googlesource.com/1034377 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/9efc0c7c0f6da1c23f870e961bd0525728a4230a/client/cros/networking/wifi_proxy.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7278a43d25f68780530732b50e465dc6da4ad759 commit 7278a43d25f68780530732b50e465dc6da4ad759 Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue May 01 20:06:48 2018 network_WiFi_WakeOnWiFiThrottling: Keep pylint happy. Fixes the following pylint warning: ************* Module network_WiFi_WakeOnWiFiThrottling W: 29, 8: Unused variable 'ap_ssid' (unused-variable) BUG=chromium:838014 TEST=None Change-Id: Ib3d327b2609fc4afde2b277a848762fa584c3a0c Reviewed-on: https://chromium-review.googlesource.com/1034380 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/7278a43d25f68780530732b50e465dc6da4ad759/server/site_tests/network_WiFi_WakeOnWiFiThrottling/network_WiFi_WakeOnWiFiThrottling.py
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9d3b7548b013268516203f86027f535ece4f4056 commit 9d3b7548b013268516203f86027f535ece4f4056 Author: Kirtika Ruchandani <kirtika@google.com> Date: Mon May 07 03:39:29 2018 wifi_proxy: Make pylint happy about exception vars Remove unused exception variables, or print them. This fixes the following pylint warnings: W: 37,56: Unused variable 'e' (unused-variable) W:320,52: Unused variable 'e' (unused-variable) BUG=chromium:838014 TEST=None Change-Id: I4c621391c2b7dfba4a13d1291a965c4bed0226eb Reviewed-on: https://chromium-review.googlesource.com/1034375 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/9d3b7548b013268516203f86027f535ece4f4056/client/cros/networking/wifi_proxy.py
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/593d8855730b761dff6374687420d9534811772d commit 593d8855730b761dff6374687420d9534811772d Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed May 16 23:42:58 2018 network_WiFi_Reset: Keep pylint happy. 1. Remove unused function argument. 2. Use loop indexes that pylint knows to ignore. This fixes: pylint server/site_tests/network_WiFi_Reset/network_WiFi_Reset.py ************* Module network_WiFi_Reset W: 59,28: Unused argument 'client' (unused-argument) W:105,12: Unused variable 'i' (unused-variable) W:108,16: Unused variable 'j' (unused-variable) BUG=chromium:838014 TEST=None Change-Id: I8cb04be0c24e33dfa8ab4939d9c9233e6bc5d79e Reviewed-on: https://chromium-review.googlesource.com/1034378 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/593d8855730b761dff6374687420d9534811772d/server/site_tests/network_WiFi_Reset/network_WiFi_Reset.py |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, May 1 2018