New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838013 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR

Blocked on:
issue 862707


Show other hotlists

Hotlists containing this issue:
bundles-follow-up


Sign in to add a comment

Share code with WebVrRenderer

Project Member Reported by lincolnfrog@chromium.org, Apr 29 2018

Issue description

WebARRenderer?

 
Labels: -Type-Bug Type-Task
Labels: XR-Device
Cc: billorr@chromium.org
Owner: lincolnfrog@chromium.org
Status: Assigned (was: Untriaged)
Components: Blink>WebXR
Components: -Blink>WebXR Blink>WebXR>AR
Cc: lincolnfrog@chromium.org cjgrant@chromium.org ddorwin@chromium.org
Owner: vollick@chromium.org
Summary: Share code with WebVrRenderer (was: Rename WebVRRenderer to make it clear it is also used for AR)
With crrev.com/c/1147218, we should no longer be sharing code, though this is the long term goal. I've reworked this bug to capture the new next step.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b07132cfd85f20d88ecc4d276f2dbce7870e9126

commit b07132cfd85f20d88ecc4d276f2dbce7870e9126
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jul 23 22:27:27 2018

[ar] Avoid using VR UI code for AR rendering

While VR and AR may one day be able to share code, this will complicate
our lives in the short term. With this change I've added an ArRenderer
to handle the modest GL work that's required by AR.

Bug: 838013
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibdbcb5729a7f70f0c63ef4c72ffd2804ed351eab
Reviewed-on: https://chromium-review.googlesource.com/1147218
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577301}
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_image_transport.cc
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_image_transport.h
[add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_renderer.cc
[add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_renderer.h
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/elements/content_element.cc
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/ui.cc
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/ui.h
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/ui_interface.h
[add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_geometry_util.cc
[add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_geometry_util.h
[rename] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_geometry_util_unittest.cc
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_gl_util.cc
[modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_gl_util.h

Blocking: 850674
Cc: vollick@chromium.org
Owner: ----
Blocking: -850674 862707
Blockedon: 862707
Blocking: -862707
Status: Available (was: Assigned)
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Labels: AR-Cleanup

Sign in to add a comment