Share code with WebVrRenderer |
|||||||||||
Issue descriptionWebARRenderer?
,
May 26 2018
,
Jun 8 2018
,
Jul 4
,
Jul 11
,
Jul 23
With crrev.com/c/1147218, we should no longer be sharing code, though this is the long term goal. I've reworked this bug to capture the new next step.
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b07132cfd85f20d88ecc4d276f2dbce7870e9126 commit b07132cfd85f20d88ecc4d276f2dbce7870e9126 Author: Ian Vollick <vollick@chromium.org> Date: Mon Jul 23 22:27:27 2018 [ar] Avoid using VR UI code for AR rendering While VR and AR may one day be able to share code, this will complicate our lives in the short term. With this change I've added an ArRenderer to handle the modest GL work that's required by AR. Bug: 838013 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibdbcb5729a7f70f0c63ef4c72ffd2804ed351eab Reviewed-on: https://chromium-review.googlesource.com/1147218 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577301} [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_image_transport.cc [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_image_transport.h [add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_renderer.cc [add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/arcore_device/ar_renderer.h [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/elements/content_element.cc [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/ui.cc [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/ui.h [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/ui_interface.h [add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_geometry_util.cc [add] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_geometry_util.h [rename] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_geometry_util_unittest.cc [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_gl_util.cc [modify] https://crrev.com/b07132cfd85f20d88ecc4d276f2dbce7870e9126/chrome/browser/vr/vr_gl_util.h
,
Jul 23
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
,
Sep 4
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by lincolnfrog@chromium.org
, Apr 29 2018