New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838012 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Stop infinite loops improvement

Reported by david.pr...@gmail.com, Apr 29 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.18 Safari/537.36

Steps to reproduce the problem:
This new feature is really very useful, but I think that it could be improved a bit to make it easy to use.

There are two problems that I see:

1. If the dev tools is closed, you can't open it directly by pressing F12 (even if you use the Chrome menu to load the dev panel, it just not works).

Suggestion: I (maybe) understand that F12 will not works because that the Chrome try check if some event handle this key (like onkeydown), but because the page is freezed on infinity loop, then the F12 is never processed. I think that after 1 freeze second the Chrome should understand that app is not respoding, so F12 should call dev tools.

--

2. The feature is very hidden. You should first stop script execution, then hold resume button, then stop again.

Suggestion: after 1 freeze second, Chrome should understand that app is not responding and display a console.log() something like "Looping running on script.js:14 seems to be infinity" and with a option to "force stop". If loop ends, then this log should be hide.

--

Maybe to detect if loop is freezed, Chrome should wait 1 second or a bit more and check if loop expression variables is modifying a long of time. If it is not changing, then could consider loop infinity and make item 1 and 2 suggestions available. If Chrome could not identify a infinity loop, then wait about 5~10 seconds and identify anyway.

What is the expected behavior?

What went wrong?
-

Did this work before? N/A 

Chrome version: 67.0.3396.18  Channel: beta
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M67
Cc: susan.boorgula@chromium.org
Labels: -Type-Bug M-68 Triaged-ET FoundIn-68 Target-68 OS-Linux OS-Mac Type-Feature
Status: Untriaged (was: Unconfirmed)
david.proweb@ Thanks for the issue.

From the above description, this is a Feature Request and suggestions for Dev tools.
Hence Marking this as Untriaged for further updates from Dev.

Thanks..

Comment 3 by alph@chromium.org, May 10 2018

Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the report.  This is especially useful when Chrome's "page unresponsive, do you want to Kill or Wait?" dialog does not show.

We should consider showing an informative console message whenever the dialog would be shown, or if any user's Console commands timeout.
Concept: https://imgur.com/a/IJ70sJc

Automatically pausing the page could work, but this requires introducing a new DevTools protocol event.
Cc: julialiang@chromium.org
Thanks loue@. Here are potential considerations we discussed:

-adding directions about changing threads
-using pause and stop icons rather than text
-assessing whether it makes sense to change 'click-and-hold' text ('long press' typically used for touchscreen devices, but would 'long click' make sense?)

Sign in to add a comment