New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837998 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
(OOO slow)
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 765462



Sign in to add a comment

testLongPressGestureFollowedByTapDoesntSelect is flaky on some platforms

Project Member Reported by donnd@google.com, Apr 29 2018

Issue description

This was recently reenabled in https://chromium-review.googlesource.com/1030770, a reland of https://chromium-review.googlesource.com/1018300, but it looks like it may have been working pretty well before then.  It seems to do well with retries.

this sequence is failing sometimes:
        clickWordNode("states-far");
        waitForGestureToClosePanelAndAssertNoSelection();


I  818.067s run_tests_on_device(0604e541003bc443)    1) testLongPressGestureFollowedByTapDoesntSelect(org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest)
I  818.067s run_tests_on_device(0604e541003bc443)    java.lang.AssertionError: Panel did not enter CLOSED state. Instead, the current state is PEEKED.
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.junit.Assert.fail(Assert.java:88)
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.junit.Assert.assertTrue(Assert.java:41)
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172)
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:194)
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:807)
I  818.067s run_tests_on_device(0604e541003bc443)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToClose(ContextualSearchManagerTest.java:799)
I  818.068s run_tests_on_device(0604e541003bc443)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForGestureToClosePanelAndAssertNoSelection(ContextualSearchManagerTest.java:850)
I  818.068s run_tests_on_device(0604e541003bc443)    	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testLongPressGestureFollowedByTapDoesntSelect(ContextualSearchManagerTest.java:1566)

 

Comment 1 by donnd@google.com, Apr 29 2018

I'm going to restrict this test to post KitKat again since that seemed to be working pretty well.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39f211f980c3fe77a79dc75ffb2d227b75e853d0

commit 39f211f980c3fe77a79dc75ffb2d227b75e853d0
Author: Donn Denman <donnd@chromium.org>
Date: Sun Apr 29 20:06:05 2018

[TTS] conditionally disable a test pre- Android L.

Disables testLongPressGestureFollowedByTapDoesntSelect on versions
before Android L because those tend to be flaky.  This was the case
until a recent CL speculatively enabled this test on all platforms.

TBR=twellington@chromium.org

BUG=837998

Change-Id: I8fe049da497f514bb2c390493fa716992258e23e
Reviewed-on: https://chromium-review.googlesource.com/1034285
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554673}
[modify] https://crrev.com/39f211f980c3fe77a79dc75ffb2d227b75e853d0/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 3 by donnd@google.com, Apr 30 2018

Status: Assigned (was: Started)
Summary: testLongPressGestureFollowedByTapDoesntSelect is flaky on some platforms (was: testLongPressGestureFollowedByTapDoesntSelect is flaky)
Components: -UI>Browser>Mobile>TouchToSearch UI>Browser>Mobile>TapToSearch
Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
Quite flaky, needs to be disabled: 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=ContextualSearchManagerTest%23testLongPress
https://screenshot.googleplex.com/tZHqGnQUgRw.png

Sign in to add a comment