New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837995 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit 15 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Null-dereference READ during 'insertUnorderedList' command

Project Member Reported by ClusterFuzz, Apr 29 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5473678884864000

Fuzzer: bj_broddelwerk
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000048
Crash State:
  chrome
  blink::CompositeEditCommand::InsertNodeAfter
  blink::ReplaceSelectionCommand::InsertAsListItems
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=545381:545393

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5473678884864000

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 29 2018

Components: Blink>Editing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 29 2018

Labels: Test-Predator-Auto-Owner
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/8e793a18ec6358414ffc337b336c93d4f6061c91 (Skip non-text svg elements in Most{For/Back}wardCaretPosition).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>Editing Blink>Editing>Command
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: Null-dereference READ during 'insertUnorderedList' command (was: Null-dereference READ in chrome)
P3/Available due to the low usage of document.execCommand('InsertUnorderedList').
Owner: tanvir.r...@samsung.com
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/230fcaff645e1c66b4b0edb2da9e0a396e089083

commit 230fcaff645e1c66b4b0edb2da9e0a396e089083
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Tue Jun 12 06:09:57 2018

Abort editingState if insertNode after a disconnected parent

Editing state should be aborted when the
node insertion is done on a parent which
is in disconnected state.

Bug:  837995 
Change-Id: I8dadf1ea837890883d971960f4a653ea71afd277
Reviewed-on: https://chromium-review.googlesource.com/1095125
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#566336}
[modify] https://crrev.com/230fcaff645e1c66b4b0edb2da9e0a396e089083/third_party/blink/renderer/core/editing/commands/composite_edit_command.cc
[modify] https://crrev.com/230fcaff645e1c66b4b0edb2da9e0a396e089083/third_party/blink/renderer/core/editing/commands/composite_edit_command_test.cc

Project Member

Comment 6 by ClusterFuzz, Jun 13 2018

ClusterFuzz has detected this issue as fixed in range 566315:566339.

Detailed report: https://clusterfuzz.com/testcase?key=5473678884864000

Fuzzer: bj_broddelwerk
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000048
Crash State:
  chrome
  blink::CompositeEditCommand::InsertNodeAfter
  blink::ReplaceSelectionCommand::InsertAsListItems
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=545381:545393
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=566315:566339

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5473678884864000

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jun 13 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5473678884864000 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment