New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837965 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR

Blocking:
issue 850674



Sign in to add a comment

Move ARCoreDeviceProviderFactory installation out of VRShellDelegate

Project Member Reported by lincolnfrog@chromium.org, Apr 29 2018

Issue description

We added the install for ARCoreDeviceProviderFactory to VRShellDelegate because that was a convenient place to do it before the VRDeviceManager initialization happens. We should move this somewhere else with similar timing but that is ARCore-specific.


 
from ddorwing@:

Looking at the code [1] that calls this, it appears that "library" might refer to chrome.so rather than GVR. Probably, we should call some AR-specific Java code that will bounce into a similar function. If such bounces are costly, we could reduce the number of bounces by creating a common XR path.

[1] https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java?rcl=5d32e5baac25a09d120e0f5d8dd53d62265f8ae0&l=1306
Cc: ijamardo@chromium.org mthiesse@chromium.org bshe@chromium.org
Labels: M-68 OS-Android
onNativeLibraryAvailable does indeed refer to the main chrome .so or all '.so's under component build.

I don't think you need to bother moving this call around. VrShellDelegate is essentially just the thing the rest of browser/ interacts with for VR-like stuff, and we really don't need to add like an 'xrdelegate' just for this.

That said, in terms of the cost of adding a second path, it's really just the cost of an extra JNI hop, which isn't very expensive.

If we ever need to add something like an 'xrdelegate' we can consider moving the initialization call there, but I don't think we even need a tracking bug for this.
Labels: -M-68 M-69
Components: Blink>WebXR
Components: -Blink>WebXR Blink>WebXR>AR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Status: WontFix (was: Assigned)
As per Michael's comment, creating a whole new path for this seems unnecessary and we can address it if more items are added in the future + no tracking bug needed.
Labels: -Pri-3 -M-69 Target-71 Pri-2
Owner: tiborg@chromium.org
Status: Started (was: WontFix)
Opening this because I have a need for this now. If the VR module is not installed we won't call VrShellDelegate.
Blocking: 850674
Labels: -Target-71 Target-72
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 30

Status: Fixed (was: Started)

Sign in to add a comment