Move ARCoreDeviceProviderFactory installation out of VRShellDelegate |
|||||||||||||
Issue descriptionWe added the install for ARCoreDeviceProviderFactory to VRShellDelegate because that was a convenient place to do it before the VRDeviceManager initialization happens. We should move this somewhere else with similar timing but that is ARCore-specific.
,
Apr 29 2018
,
Apr 29 2018
onNativeLibraryAvailable does indeed refer to the main chrome .so or all '.so's under component build. I don't think you need to bother moving this call around. VrShellDelegate is essentially just the thing the rest of browser/ interacts with for VR-like stuff, and we really don't need to add like an 'xrdelegate' just for this. That said, in terms of the cost of adding a second path, it's really just the cost of an extra JNI hop, which isn't very expensive. If we ever need to add something like an 'xrdelegate' we can consider moving the initialization call there, but I don't think we even need a tracking bug for this.
,
May 28 2018
,
Jul 4
,
Jul 11
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
,
Aug 14
As per Michael's comment, creating a whole new path for this seems unnecessary and we can address it if more items are added in the future + no tracking bug needed.
,
Sep 25
Opening this because I have a need for this now. If the VR module is not installed we won't call VrShellDelegate.
,
Sep 25
,
Oct 24
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd942c988232b846b3ce8e98d2fb6370a247b283 commit bd942c988232b846b3ce8e98d2fb6370a247b283 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Oct 30 18:38:18 2018 [ar] Make AR initialization independent from VR This is a precursor to have AR and VR be in separate dynamic feature modules. Bug: 837965 Change-Id: I0fb15971db49b858d808f78d93b77a72819cad8c Reviewed-on: https://chromium-review.googlesource.com/c/1298238 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603971} [modify] https://crrev.com/bd942c988232b846b3ce8e98d2fb6370a247b283/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/bd942c988232b846b3ce8e98d2fb6370a247b283/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java [add] https://crrev.com/bd942c988232b846b3ce8e98d2fb6370a247b283/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegate.java [modify] https://crrev.com/bd942c988232b846b3ce8e98d2fb6370a247b283/chrome/android/java_sources.gni [modify] https://crrev.com/bd942c988232b846b3ce8e98d2fb6370a247b283/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc [modify] https://crrev.com/bd942c988232b846b3ce8e98d2fb6370a247b283/chrome/browser/android/vr/vr_shell_delegate.cc
,
Oct 30
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by lincolnfrog@chromium.org
, Apr 29 2018