New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 837944 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR

Blocked on:
issue 846521



Sign in to add a comment

Delay ARCoreDevice frame requests until everything is initialized and then call the callback.

Project Member Reported by lincolnfrog@chromium.org, Apr 28 2018

Issue description

We just reject requests for frames from ARCoreDevice if the initialization process isn't complete. Instead, we should store the callback and call later when initialization has finished.


 
Labels: -Pri-3 M-68 OS-Android Pri-2
 Issue 838317  has been merged into this issue.
This is no longer needed because the session is correctly created when the request is fulfilled. In normal operations, there won'g be any requests for frame while the session is not initialized. If the render process makes an untrusted call to request a frame when the session is not initialized, returning nullptr and not storing the callback should be the right approach.
Added a container to store the deferred callbacks in CL 1046112.
Labels: -M-68 M-69
Decided to no longer pursue this approach for now.
Blockedon: 846521
This TODO still exists in the code. I think issue 846521 would address this issue by preventing this scenario from happening.
 Issue 837118  has been merged into this issue.
Components: Blink>WebXR
Components: -Blink>WebXR Blink>WebXR>AR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
EstimatedDays: 1
Only estimating 1 day for this since 2 of the three days on 846521 are for setting up a system for this. 
Labels: AR-Cleanup
Cc: klausw@chromium.org ijamardo@chromium.org
Labels: -M-69
Owner: lincolnfrog@chromium.org

Sign in to add a comment