New issue
Advanced search Search tips

Issue 837934 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::NamesMap::Set

Project Member Reported by ClusterFuzz, Apr 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6319773080879104

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000000000b
Crash State:
  blink::NamesMap::Set
  blink::Element::AttributeChanged
  blink::HTMLElement::AttributeChanged
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=553033:553034

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6319773080879104

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 28 2018

Components: Blink>DOM Blink>HTML
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 28 2018

Labels: Test-Predator-Auto-Owner
Owner: fergal@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/1b6d8638caf9c57f132175426f795a10eb4c769c (CSS: Parse partmap attribute into map in Element).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by fergal@chromium.org, Apr 29 2018

Adding logging to AttributeChanged tells me

params.new_value: <null>

Looks like the code needs to be special-cased for g_null_atom.
Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a071bd787a15f928559729617352d4956d6953f

commit 5a071bd787a15f928559729617352d4956d6953f
Author: Fergal Daly <fergal@chromium.org>
Date: Tue May 01 03:14:12 2018

DOM: Add check for IsNull to NamesMap::Set.

Bug:  837934 
Change-Id: I00bd7c886b5416ea5cec42fa6f9cbe10e18aab7a
Reviewed-on: https://chromium-review.googlesource.com/1036704
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554985}
[modify] https://crrev.com/5a071bd787a15f928559729617352d4956d6953f/third_party/blink/renderer/core/dom/names_map.cc
[modify] https://crrev.com/5a071bd787a15f928559729617352d4956d6953f/third_party/blink/renderer/core/dom/names_map_test.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, May 1 2018

ClusterFuzz has detected this issue as fixed in range 554984:554987.

Detailed report: https://clusterfuzz.com/testcase?key=6319773080879104

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000000000b
Crash State:
  blink::NamesMap::Set
  blink::Element::AttributeChanged
  blink::HTMLElement::AttributeChanged
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=553033:553034
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=554984:554987

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6319773080879104

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, May 1 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6319773080879104 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment