New issue
Advanced search Search tips

Issue 837932 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ClipPaintPropertyNode::GetClipCache

Project Member Reported by ClusterFuzz, Apr 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5134309191843840

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::ClipPaintPropertyNode::GetClipCache
  blink::GeometryMapper::LocalToAncestorClipRectInternal
  blink::GeometryMapper::LocalToAncestorClipRect
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=554620:554628

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5134309191843840

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 28 2018

Components: Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 28 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/70fc0b018c9517558b7aa2be00edf2debb449123 ([CI] Make paint property nodes non-ref-counted).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/887383b30842d9d9006e11bb6932660a3cb5b1b7

commit 887383b30842d9d9006e11bb6932660a3cb5b1b7
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Apr 28 21:05:03 2018

Revert "[CI] Make paint property nodes non-ref-counted"

This reverts commit 70fc0b018c9517558b7aa2be00edf2debb449123.

Reason for revert: Caused bugs found by clusterfuzz

Original change's description:
> [CI] Make paint property nodes non-ref-counted
> 
> Now all paint property nodes are owned by ObjectPaintProperties
> (and LocalFrameView temporarily before removing non-RLS mode).
> Others just use raw pointers or references.
> 
> Bug: 833496
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae
> Reviewed-on: https://chromium-review.googlesource.com/1031101
> Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554626}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org

Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833496, 837932 , 837943 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1034292
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554653}
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/block_painter.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/find_paint_offset_and_visual_rect_needing_update.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/find_properties_needing_update.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/fragment_data.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/object_paint_properties.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/core/paint/view_painter_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/geometry_mapper.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/geometry_mapper_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/paint_chunk.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/paint_chunker_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/paint_property_node_test.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/property_tree_state.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/property_tree_state_test.cc
[add] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.cc
[add] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/testing/paint_property_test_helpers.h
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/testing/test_paint_artifact.cc
[modify] https://crrev.com/887383b30842d9d9006e11bb6932660a3cb5b1b7/third_party/blink/renderer/platform/testing/test_paint_artifact.h

Project Member

Comment 4 by ClusterFuzz, Apr 29 2018

ClusterFuzz has detected this issue as fixed in range 554652:554653.

Detailed report: https://clusterfuzz.com/testcase?key=5134309191843840

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::ClipPaintPropertyNode::GetClipCache
  blink::GeometryMapper::LocalToAncestorClipRectInternal
  blink::GeometryMapper::LocalToAncestorClipRect
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=554620:554628
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=554652:554653

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5134309191843840

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Apr 29 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5134309191843840 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f911e11e7f6b5c0d6f5ee694a9871de6619889f7

commit f911e11e7f6b5c0d6f5ee694a9871de6619889f7
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Jun 02 05:08:30 2018

Reland "[CI] Make paint property nodes non-ref-counted"

This reverts commit 887383b30842d9d9006e11bb6932660a3cb5b1b7.

Reason for revert: Retry in M69.

Original change's description:
> Revert "[CI] Make paint property nodes non-ref-counted"
>
> This reverts commit 70fc0b018c9517558b7aa2be00edf2debb449123.
>
> Reason for revert: Caused bugs found by clusterfuzz
>
> Original change's description:
> > [CI] Make paint property nodes non-ref-counted
> >
> > Now all paint property nodes are owned by ObjectPaintProperties
> > (and LocalFrameView temporarily before removing non-RLS mode).
> > Others just use raw pointers or references.
> >
> > Bug: 833496
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae
> > Reviewed-on: https://chromium-review.googlesource.com/1031101
> > Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#554626}
>
> TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org
>
> Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 833496, 837932 , 837943 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/1034292
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554653}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 833496,  837932 ,  837943 
Change-Id: I0b4ef70db1f1f211ba97c30d617225355c750992
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1083491
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563930}
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/block_painter.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/find_paint_offset_and_visual_rect_needing_update.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/fragment_data.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/object_paint_properties.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/core/paint/view_painter_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/geometry_mapper.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/geometry_mapper_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/paint_chunk.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/paint_chunker_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/paint_property_node_test.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/property_tree_state.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/property_tree_state_test.cc
[delete] https://crrev.com/95f5260501ac2660f29fb98ab5cb351a956c1dab/third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.cc
[delete] https://crrev.com/95f5260501ac2660f29fb98ab5cb351a956c1dab/third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/testing/paint_property_test_helpers.h
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/testing/test_paint_artifact.cc
[modify] https://crrev.com/f911e11e7f6b5c0d6f5ee694a9871de6619889f7/third_party/blink/renderer/platform/testing/test_paint_artifact.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8040fa96ca6032e5a699e1ddf6bded788afa0a01

commit 8040fa96ca6032e5a699e1ddf6bded788afa0a01
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sun Jun 03 20:17:54 2018

Partly revert "Reland "[CI] Make paint property nodes non-ref-counted""

This reverts commit f911e11e7f6b5c0d6f5ee694a9871de6619889f7.

Reason for revert: Clusterfuzz still reported problems.

This is not a full revert, but keep the non-ref-counted function
interfaces and shorter test code so that it will be easier to switch
to full non-ref-counted again.

Original change's description:
> Reland "[CI] Make paint property nodes non-ref-counted"
>
> This reverts commit 887383b30842d9d9006e11bb6932660a3cb5b1b7.
>
> Reason for revert: Retry in M69.
>
> Original change's description:
> > Revert "[CI] Make paint property nodes non-ref-counted"
> >
> > This reverts commit 70fc0b018c9517558b7aa2be00edf2debb449123.
> >
> > Reason for revert: Caused bugs found by clusterfuzz
> >
> > Original change's description:
> > > [CI] Make paint property nodes non-ref-counted
> > >
> > > Now all paint property nodes are owned by ObjectPaintProperties
> > > (and LocalFrameView temporarily before removing non-RLS mode).
> > > Others just use raw pointers or references.
> > >
> > > Bug: 833496
> > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > > Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae
> > > Reviewed-on: https://chromium-review.googlesource.com/1031101
> > > Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#554626}
> >
> > TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org
> >
> > Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 833496, 837932 , 837943 
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Reviewed-on: https://chromium-review.googlesource.com/1034292
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#554653}
>
> TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 833496,  837932 ,  837943 
> Change-Id: I0b4ef70db1f1f211ba97c30d617225355c750992
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/1083491
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563930}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org

Change-Id: I1491f062f2e337cdf329c26742cef33437baca0c
Bug: 833496,  849033 ,  849036 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1083700
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563974}
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/core/paint/find_paint_offset_and_visual_rect_needing_update.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/core/paint/fragment_data.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/core/paint/object_paint_properties.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper_test.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator_test.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/paint_chunk.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/paint_property_node_test.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/property_tree_state_test.cc
[add] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.cc
[add] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.cc
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h
[modify] https://crrev.com/8040fa96ca6032e5a699e1ddf6bded788afa0a01/third_party/blink/renderer/platform/testing/paint_property_test_helpers.h

Sign in to add a comment